Skip to content

REC-102: release: multiple fixes #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jayconrod merged 4 commits into from
Nov 5, 2024
Merged

REC-102: release: multiple fixes #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff4acd7
fix semver regexp
jayconrod Nov 5, 2024
7c4ebe6
name artifacts for build jobs
jayconrod Nov 5, 2024
218f462
add .exe extension to windows binaries
jayconrod Nov 5, 2024
7338a3e
basename
jayconrod Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ jobs:
- uses: actions/upload-artifact@v4
if: success()
with:
name: linux
Copy link

@benjaminp benjaminp Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which part is this fixing?

Copy link
Contributor Author

@jayconrod jayconrod Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the name is not set, they all write to artifact. I think the last job wins. A customer pointed out to us that v0.0.9 lacked a Windows artifact: this is why.

Copy link

@benjaminp benjaminp Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see this names the artifact.

path: _out
if-no-files-found: error
retention-days: 1
Expand Down Expand Up @@ -143,6 +144,7 @@ jobs:
- uses: actions/upload-artifact@v4
if: success()
with:
name: ${{ matrix.os }}
path: _out
if-no-files-found: error
retention-days: 1
Expand Down
4 changes: 3 additions & 1 deletion infra/release-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ sign_and_notarize_binary () {
return
}

EXT=
case "${OS}" in
macos)
TARGETS=(
Expand All @@ -88,6 +89,7 @@ windows)
TARGETS=(
//cmd/engflow_auth:engflow_auth_windows_x64
)
EXT=.exe
;;
esac

Expand All @@ -104,5 +106,5 @@ trap uninstall_cert EXIT
for target in "${TARGETS[@]}"; do
target_file=$(bazel cquery --output=files "${target}")
sign_and_notarize_binary "${target_file}"
cp "${target_file}" _out/
cp "${target_file}" "_out/$(basename ${target_file})${EXT}"
done
6 changes: 4 additions & 2 deletions infra/release-check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@ if [[ -z "${RELEASE_VERSION:-}" ]]; then
exit 1
fi

# Taken from https://semver.org/, with a `v` prepended
readonly SEMVER_REGEX='^v(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)(-((0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(\.(0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(\+([0-9a-zA-Z-]+(\.[0-9a-zA-Z-]+)*))?$'
# Taken from https://semver.org/,
# prepended 'v', required by Go;
# replaced \d with [0-9] for compatibility with grep regex flavor.
readonly SEMVER_REGEX='^v(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)(-((0|[1-9][0-9]*|[0-9]*[a-zA-Z-][0-9a-zA-Z-]*)(\.(0|[1-9][0-9]*|[0-9]*[a-zA-Z-][0-9a-zA-Z-]*))*))?(\+([0-9a-zA-Z-]+(\.[0-9a-zA-Z-]+)*))?$'

# Supplied version string must follow semver
if ! grep --quiet --extended-regexp "${SEMVER_REGEX}" <<<${RELEASE_VERSION}; then
Expand Down