REC-102: release: multiple fixes #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
benjaminp
approved these changes
Nov 5, 2024
| - uses: actions/upload-artifact@v4 | ||
| if: success() | ||
| with: | ||
| name: linux |
Contributor
Author
There was a problem hiding this comment.
If the name is not set, they all write to artifact. I think the last job wins. A customer pointed out to us that v0.0.9 lacked a Windows artifact: this is why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set uploaded artifact names uniquely so that different jobs upload separate artifacts. The default was to overwrite the same artifact. No such setting is needed for downloading: the default is to download all artifacts.
Fixed the regular expression used to validate semantic versions. We used a PCRE-compatible regex from semver.org, but grep doesn't use PCRE, and different versions of grep (on Linux and macOS at least) interpret the same expression differently. Hopefully we've landed on something that works.
Added an .exe extension to the Windows artifact.