-
Notifications
You must be signed in to change notification settings - Fork 244
Add mbed os support #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mbed os support #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @AGlass0fMilk , please rebase to the head of the develop branch (1.7.3 version) and follow instructions about code formatting as described here: https://github.com/EmbeddedRPC/erpc/wiki/Contributing (avoid using tabs).
Also, could you point to an example project with mbedOS that we could use for build testing? Thanks.
Hi @MichalPrincNXP, I rebased with the current head of the develop branch and I reformatted my changes to remove tabs. You can find example projects using MbedOS here: https://github.com/EmbeddedPlanet/mbed-rpc and here: https://github.com/EmbeddedPlanet/ep-oc-example-mbed-rpc |
Hi @AGlass0fMilk, |
Hello @AGlass0fMilk , did you have a chance to read my last comment? Thank you. |
Hi @MichalPrincNXP. Yes I will rebase soon. This is again relevant to customer projects so I'll be able to devote some more time to it. I can look into setting up the travis as well. |
2b903bd
to
5313853
Compare
@MichalPrincNXP I rebased this PR to develop, can you review? |
Thank you @AGlass0fMilk for rebasing, your pull request looks good and could be merged. |
@AGlass0fMilk , I have missed that the correct name of the added cpp files should be erpc_threading_mbed.cpp (instead of erpc_port_mbed.cpp) to be aligned with other port layer files naming. Just note, that I will do the renaming. |
…ayer files naming Signed-off-by: Michal Princ (nxa17570) <michal.princ@nxp.com>
…ther port layer files naming Signed-off-by: Michal Princ (nxa17570) <michal.princ@nxp.com>
Add support to use erpc with Mbed-OS.