Skip to content

Conversation

AGlass0fMilk
Copy link
Contributor

Add support to use erpc with Mbed-OS.

Copy link
Member

@MichalPrincNXP MichalPrincNXP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @AGlass0fMilk , please rebase to the head of the develop branch (1.7.3 version) and follow instructions about code formatting as described here: https://github.com/EmbeddedRPC/erpc/wiki/Contributing (avoid using tabs).
Also, could you point to an example project with mbedOS that we could use for build testing? Thanks.

@AGlass0fMilk
Copy link
Contributor Author

AGlass0fMilk commented Jan 7, 2020

Hi @MichalPrincNXP,

I rebased with the current head of the develop branch and I reformatted my changes to remove tabs.

You can find example projects using MbedOS here:

https://github.com/EmbeddedPlanet/mbed-rpc

and here: https://github.com/EmbeddedPlanet/ep-oc-example-mbed-rpc

@MichalPrincNXP
Copy link
Member

Hi @AGlass0fMilk,
your pull request looks good. We prefer the PR integration into the develop branch first, the main branch should be used for main releases. I have added this note into the https://github.com/EmbeddedRPC/erpc/wiki/Contributing As per this, could you please rebase your PR to the develop branch?
As for the mbedOS app. build testing, this would require certain effort to setup the build environment on our side. Because it is out of our focus now we can accept your PR, supposing you have tested the mbedOS port in your project. Once there are any issues reported to the mbedOS port we will route them to you. Are you OK?
Another way how to ensure mbedOS build testing is the Travis. Would you be able to prepare erpc project .travis.yml update to add an mbedOS erpc app build? This could be done as a separate PR. Thanks.

@MichalPrincNXP
Copy link
Member

Hello @AGlass0fMilk , did you have a chance to read my last comment? Thank you.

@AGlass0fMilk
Copy link
Contributor Author

Hi @MichalPrincNXP. Yes I will rebase soon. This is again relevant to customer projects so I'll be able to devote some more time to it.

I can look into setting up the travis as well.

@AGlass0fMilk AGlass0fMilk force-pushed the add-mbed-os-support branch from 2b903bd to 5313853 Compare April 3, 2020 10:34
@AGlass0fMilk
Copy link
Contributor Author

@MichalPrincNXP I rebased this PR to develop, can you review?

@AGlass0fMilk AGlass0fMilk changed the base branch from master to develop April 3, 2020 10:38
@MichalPrincNXP
Copy link
Member

Thank you @AGlass0fMilk for rebasing, your pull request looks good and could be merged.
Once there is any question about mbedOS support it will be routed to you as stated in my previous comment. It would be also good if you could invest time to the Travis update, preparing another pull request.

@MichalPrincNXP MichalPrincNXP merged commit 9a82e6e into EmbeddedRPC:develop Apr 6, 2020
@MichalPrincNXP
Copy link
Member

@AGlass0fMilk , I have missed that the correct name of the added cpp files should be erpc_threading_mbed.cpp (instead of erpc_port_mbed.cpp) to be aligned with other port layer files naming. Just note, that I will do the renaming.
Any progress on the Travis?
Thanks.

MichalPrincNXP added a commit that referenced this pull request Apr 17, 2020
…ayer files naming

Signed-off-by: Michal Princ (nxa17570) <michal.princ@nxp.com>
Hadatko pushed a commit to Hadatko/erpc that referenced this pull request Feb 10, 2021
…ther port layer files naming

Signed-off-by: Michal Princ (nxa17570) <michal.princ@nxp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants