Skip to content

Conversation

ierturk
Copy link

@ierturk ierturk commented May 2, 2021

In this PR includes

  • Azure RTOS ThreadX threading support (Thread, Mutex, Semaphore)
  • Building the library with CMake

Test configuration

  • Nucleo STM32H743ZI2 board as rpc server over UART transport @ 115200 Baud, 8n1
  • Toradex iMX8m Mini SOM DK (Torizon/Yocto Linux) as rpc client over serial transport @ 115200 Baud, 8n1

@Hadatko
Copy link
Member

Hadatko commented May 2, 2021

Hi and thank you very much for new OS port. Amazing.

@ierturk
Copy link
Author

ierturk commented May 2, 2021

Thank you for your comment @Hadatko

Copy link
Member

@MichalPrincNXP MichalPrincNXP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ierturk ,
thanks for this ThreadX support for the eRPC. In general, it looks fine. Here are my comments:

  • you are using erpc_port_stdlib.cpp in the cmake file but erpc_port_threadx.cpp (missing in erpc_c\port) should be used/created (like for other OSes)
  • I am not sure about adding the cmake file, we have not been supporting them since now, did you have a chance to use make/makefile? @Hadatko what is your opinion on that?
  • similar to #81 , we are not able to test and maintain the ThreadX support, are you OK with routing community questions/issues about ThreadX support to you to be addressed?

Thank you
Michal

@Hadatko
Copy link
Member

Hadatko commented May 12, 2021

Hi, i am not against CmakeList usage. Many people were requesting CMakeList instead of Makefiles. But origin author was against CmakeLists usage. But i don't remember a reason.

@ierturk
Copy link
Author

ierturk commented May 12, 2021

Hi @MichalPrincNXP,
Thanks for the review. Please find the answer under your comment.

  • you are using erpc_port_stdlib.cpp in the cmake file but erpc_port_threadx.cpp (missing in erpc_c\port) should be used/created (like for other OSes)

    In my case, using the erpc_port_stdlib.cpp doesn't cause any problem. However I can add a separate port file for ThreadX.

  • I am not sure about adding the cmake file, we have not been supporting them since now, did you have a chance to use make/makefile? @Hadatko what is your opinion on that?

    You can simply ignore it if it cause any inconvenience. No need a Makefile because it is not related with Linux/Windows OS tools. Also you can generate Unix Makefile from CMakeList.

  • similar to Add mbed os support #81 , we are not able to test and maintain the ThreadX support, are you OK with routing community questions/issues about ThreadX support to you to be addressed?

    Yes, I am. If you are OK, you can forward any issue related the ThreadX support.

Thanks and regards,
Ibrahim

@MichalPrincNXP
Copy link
Member

Hello @ierturk , thanks for the response and the commitment to handle ThreadX-related questions/issues. As for erpc_port_threadx.cpp I would prefer to add it. As for CmakeList, I would prefer to remove it as it is not systematic when there is no generic Cmake support now. We can decide later to support it, ok? Could you please prepare the PR update? Once done I will merge this PR. Thank you.

@ierturk
Copy link
Author

ierturk commented May 12, 2021

Hi @MichalPrincNXP,
I'll update the PR as per your request and let you know. I'll remove the CMakeList file and create a separate port file.
Regards.

@ierturk
Copy link
Author

ierturk commented May 12, 2021

Hi @MichalPrincNXP,
I've already modifed source as per your request, tested on my hardware and updated the PR.
Regards,
Ibrahim

Copy link
Member

@MichalPrincNXP MichalPrincNXP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, will integrate it.

@MichalPrincNXP MichalPrincNXP merged commit 9db5055 into EmbeddedRPC:develop May 13, 2021
@Hadatko Hadatko mentioned this pull request Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants