-
Notifications
You must be signed in to change notification settings - Fork 244
Feature Threading support for ThreadX #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Threading support for ThreadX #175
Conversation
Hi and thank you very much for new OS port. Amazing. |
Thank you for your comment @Hadatko |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ierturk ,
thanks for this ThreadX support for the eRPC. In general, it looks fine. Here are my comments:
- you are using erpc_port_stdlib.cpp in the cmake file but erpc_port_threadx.cpp (missing in erpc_c\port) should be used/created (like for other OSes)
- I am not sure about adding the cmake file, we have not been supporting them since now, did you have a chance to use make/makefile? @Hadatko what is your opinion on that?
- similar to #81 , we are not able to test and maintain the ThreadX support, are you OK with routing community questions/issues about ThreadX support to you to be addressed?
Thank you
Michal
Hi, i am not against CmakeList usage. Many people were requesting CMakeList instead of Makefiles. But origin author was against CmakeLists usage. But i don't remember a reason. |
Hi @MichalPrincNXP,
Thanks and regards, |
Hello @ierturk , thanks for the response and the commitment to handle ThreadX-related questions/issues. As for erpc_port_threadx.cpp I would prefer to add it. As for CmakeList, I would prefer to remove it as it is not systematic when there is no generic Cmake support now. We can decide later to support it, ok? Could you please prepare the PR update? Once done I will merge this PR. Thank you. |
Hi @MichalPrincNXP, |
* Removed CMakeLists.txt
Hi @MichalPrincNXP, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, will integrate it.
In this PR includes
Test configuration