-
Notifications
You must be signed in to change notification settings - Fork 20
[tess.example.yml] arranging TeSS::Config.feature list
#1224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kennethrioja
wants to merge
1
commit into
ElixirTeSS:master
Choose a base branch
from
kennethrioja:tess-yml-style
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+27
−15
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -146,33 +146,45 @@ default: &default | |||||
| focused: 13 | ||||||
| header_notice: # HTML to display above the header | ||||||
| feature: | ||||||
| elearning_materials: false | ||||||
| # TeSS main resources | ||||||
| events: true | ||||||
| materials: true | ||||||
| nodes: false | ||||||
| elearning_materials: false | ||||||
| workflows: true | ||||||
| collections: true | ||||||
| learning_paths: false | ||||||
| content_providers: true | ||||||
| subscription: true | ||||||
| trainers: false | ||||||
| workflows: true | ||||||
| sources: false | ||||||
| user_source_creation: true | ||||||
| edit_suggestions: false | ||||||
| nodes: false | ||||||
| spaces: false | ||||||
|
|
||||||
| # Resources' features | ||||||
| subscription: true | ||||||
| geocoding: false | ||||||
| sticky_navbar: false # when true, allows navbar (and header_notice if enabled) to stick to the top of the window and shrink when scrolling | ||||||
| # Possible features to disable: | ||||||
| # biotools, topics, operations, sponsors, fairshare, county, ardc_fields_of_research, | ||||||
| # other_types, subsets, syllabus, approved_editors, address_finder | ||||||
| disabled: ['ardc_fields_of_research', 'other_types', 'subsets', 'syllabus', 'approved_editors'] | ||||||
| materials_disabled: [] | ||||||
| content_providers_disabled: [] | ||||||
| bioschemas_testing: false | ||||||
| learning_paths: false | ||||||
| collection_curation: true | ||||||
| spaces: false | ||||||
| topics: true | ||||||
|
|
||||||
| # User login | ||||||
| invitation: false | ||||||
| registration: true | ||||||
| login_through_oidc_only: false # when true, only the first oidc authentication will be available in TeSS, useful when you have your org SSO. Be careful! invitation and registration must be false when using this feature. | ||||||
| login_through_oidc_only: false # when true, only the first oidc authentication will be available in TeSS, useful when you have your org SSO. Caution! invitation and registration must be false when using this feature. | ||||||
|
|
||||||
| # User rights | ||||||
| user_source_creation: true | ||||||
| trainers: false | ||||||
| edit_suggestions: false | ||||||
|
|
||||||
| # UI | ||||||
| sticky_navbar: false # when true, allows navbar (and header_notice if enabled) to stick to the top of the window and shrink when scrolling | ||||||
|
|
||||||
| # Possible features to disable: | ||||||
| # biotools, topics, operations, sponsors, fairshare, county, ardc_fields_of_research, | ||||||
| # other_types, subsets, syllabus, approved_editors address_finder, | ||||||
|
||||||
| # other_types, subsets, syllabus, approved_editors address_finder, | |
| # other_types, subsets, syllabus, approved_editors, address_finder, |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
topics: truefeature flag appears to be a new addition rather than a reorganization of existing configuration. However, the codebase doesn't check forTeSS::Config.feature['topics']orTeSS::Config.feature[:topics]. Instead, the code checks if 'topics' is included in theTeSS::Config.feature['disabled']array (see app/models/event.rb:202 and app/models/material.rb:139). Adding this flag here won't have any effect on the application's behavior and creates confusion about how topics are actually controlled. Consider removing this line or clarifying if this is intended as a new feature flag with corresponding code changes.