Skip to content

Conversation

@kennethrioja
Copy link
Contributor

Summary of changes

  • Organizing the list of features in tess.example.yml

Motivation and context

  • As I am starting to add a certain number of features, it would make sense to arrange them instead of just randomly throwing each feature in the feature bag – as an LLM may sell it "This drastically improves the DX"
  • For new TeSS maintainers this arrangement might help + I can see this list being matched with a devs' documentation that explains all features and its effects/changes on the platform.

Checklist

  • I have read and followed the CONTRIBUTING guide.
  • I confirm that I have the authority necessary to make this contribution on behalf of its copyright owner and agree
    to license it to the TeSS codebase under the
    BSD license.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reorganizes the feature configuration in tess.example.yml to improve readability and maintainability by grouping related features into logical categories. The changes add section comments to categorize features into "TeSS main resources", "Resources' features", "User login", "User rights", and "UI" sections.

Changes:

  • Reorganized feature flags into logical, commented sections for better clarity
  • Updated the "Possible features to disable" comment to include additional options
  • Minor comment wording adjustment from "Be careful!" to "Caution!"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


# Possible features to disable:
# biotools, topics, operations, sponsors, fairshare, county, ardc_fields_of_research,
# other_types, subsets, syllabus, approved_editors address_finder,
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a missing comma after "approved_editors" in the list of possible features to disable. The list should have commas between all items.

Suggested change
# other_types, subsets, syllabus, approved_editors address_finder,
# other_types, subsets, syllabus, approved_editors, address_finder,

Copilot uses AI. Check for mistakes.
learning_paths: false
collection_curation: true
spaces: false
topics: true
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The topics: true feature flag appears to be a new addition rather than a reorganization of existing configuration. However, the codebase doesn't check for TeSS::Config.feature['topics'] or TeSS::Config.feature[:topics]. Instead, the code checks if 'topics' is included in the TeSS::Config.feature['disabled'] array (see app/models/event.rb:202 and app/models/material.rb:139). Adding this flag here won't have any effect on the application's behavior and creates confusion about how topics are actually controlled. Consider removing this line or clarifying if this is intended as a new feature flag with corresponding code changes.

Suggested change
topics: true

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants