Skip to content

🔧 💥 #198: Expose more Cohere params #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

roma-glushko
Copy link
Member

@roma-glushko roma-glushko commented Apr 10, 2024

Revisited all Cohere params to add missing useful things and removed ones that don't make a lot of sense.

Changes

  • Fixed validation of nested arrays, so it can now reach all structures including provider params
  • Removed ChatHistory & ConversationID fields from the params
  • Added a bunch of other params like max_tokens, penalties, k, p, etc.
  • Added validations to some params

@roma-glushko roma-glushko self-assigned this Apr 10, 2024
@roma-glushko roma-glushko linked an issue Apr 10, 2024 that may be closed by this pull request
@roma-glushko roma-glushko added api:http provider:cohere size:small model:language type:breaking 💥 Introduces a breaking changes to API, configuration or behavior introduced before labels Apr 10, 2024
@roma-glushko roma-glushko changed the title 🔧 #198: Expose more Cohere params 🔧 💥 #198: Expose more Cohere params Apr 10, 2024
@roma-glushko roma-glushko marked this pull request as draft April 10, 2024 20:31
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 23.07692% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 67.22%. Comparing base (de3677e) to head (de16e31).

Files Patch % Lines
pkg/providers/cohere/chat.go 9.09% 10 Missing ⚠️
pkg/providers/cohere/chat_stream.go 0.00% 10 Missing ⚠️
pkg/config/provider.go 40.00% 9 Missing ⚠️
pkg/gateway.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #199       +/-   ##
============================================
+ Coverage         0   67.22%   +67.22%     
============================================
  Files            0       78       +78     
  Lines            0     3588     +3588     
============================================
+ Hits             0     2412     +2412     
- Misses           0     1048     +1048     
- Partials         0      128      +128     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roma-glushko roma-glushko marked this pull request as ready for review April 11, 2024 17:43
@roma-glushko roma-glushko marked this pull request as draft April 11, 2024 17:43
@roma-glushko roma-glushko marked this pull request as ready for review April 15, 2024 16:02
@roma-glushko roma-glushko requested a review from mkrueger12 April 15, 2024 16:03
@roma-glushko roma-glushko merged commit 8e95a4f into develop Apr 16, 2024
@roma-glushko roma-glushko deleted the 198-extend-cohere-params branch April 16, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api:http model:language provider:cohere size:small type:breaking 💥 Introduces a breaking changes to API, configuration or behavior introduced before
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔧 [Lang] Cohere: Expose most chat params
1 participant