Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 [Lang] Cohere: Expose most chat params #198

Closed
roma-glushko opened this issue Apr 10, 2024 · 0 comments · Fixed by #199
Closed

🔧 [Lang] Cohere: Expose most chat params #198

roma-glushko opened this issue Apr 10, 2024 · 0 comments · Fixed by #199
Assignees
@roma-glushko
Labels
api:http good first issue Good for newcomers help wanted Extra attention is needed model:language provider:cohere size:small type:breaking 💥 Introduces a breaking changes to API, configuration or behavior introduced before type:enhancement New feature or request
Milestone
Glide: Public Pre...

Comments

@roma-glushko
Copy link
Member

Cohere Integration lacks a lot of useful parameters to be exposed like seed, k, p:

Screenshot 2024-04-10 at 23 18 03

Some params were renamed/mismatch the naming in the cohere docs:
https://docs.cohere.com/reference/chat

Let's fix these issues
@roma-glushko roma-glushko changed the title [Lang] Cohere: Expose most chat params 🔧 [Lang] Cohere: Expose most chat params Apr 10, 2024
@roma-glushko roma-glushko added the type:breaking 💥 Introduces a breaking changes to API, configuration or behavior introduced before label Apr 10, 2024
@roma-glushko roma-glushko self-assigned this Apr 10, 2024
roma-glushko added a commit that referenced this issue Apr 10, 2024
@roma-glushko
#198: Updated the existing params
1105ec1
@roma-glushko roma-glushko linked a pull request Apr 10, 2024 that will close this issue
🔧 💥 #198: Expose more Cohere params #199
Merged
roma-glushko added a commit that referenced this issue Apr 15, 2024
@roma-glushko
#198: Added validation to Cohere params & fixed validation in general…
de16e31 
…, so it reaches to nesting structs
@roma-glushko roma-glushko added this to the Glide: Public Preview milestone Apr 15, 2024
roma-glushko added a commit that referenced this issue Apr 16, 2024
@roma-glushko
🔧 💥 #198: Expose more Cohere params (#199)
8e95a4f 
- Fixed validation of nested arrays, so it can now reach all structures including provider params
- Removed ChatHistory & ConversationID fields from the params
- Added a bunch of other params like max_tokens, penalties, k, p, etc.
- Added validations to some params
This was referenced Apr 16, 2024
Open
Merged
roma-glushko added a commit that referenced this issue Apr 16, 2024
@roma-glushko
📦 v0.0.3-rc.2 (#212)
b066eb0 
Final major improvements to streaming chat workflow. Fixed issues with Cohere streaming chat. 
Expanded and revisited Cohere params in config.

## Changelog

### Added

- 🔧 #195 #196: Set router ctx in stream chunks & handle end of stream in case of some errors (@roma-glushko)
- 🐛🔧 #197: Handle max_tokens & content_filtered finish reasons across OpenAI, Azure and Cohere (@roma-glushko)

### Changed

- 🔧 💥 #198: Expose more Cohere params & fixing validation of provider params in config (breaking change) (@roma-glushko)
- 🔧 #186: Rendering Durations in a human-friendly way (@roma-glushko)

### Fixed

- 🐛 #209: Embed Swagger specs into binary to fix panics caused by missing swagger.yaml file (@roma-glushko)
- 🐛 #200: Implemented a custom json per line stream reader to read Cohere chat streams correctly (@roma-glushko)
@roma-glushko roma-glushko mentioned this issue Apr 16, 2024
Merged
roma-glushko added a commit that referenced this issue Apr 16, 2024
@roma-glushko
📦 v0.0.3 (#215)
754af34 
## Summary

✨ Bringing support for streaming chat in Glide (integrated with OpenAI, Azure OpenAI and Cohere)
✨ Started handling 401 errors to mark models as premaritally unavailable (e.g. when API key was not correct)
🐛 Fixing the panic related to swagger.yaml file
🐛 Fixing Anthropic chat workflow by passing API key correctly
🔧 Improved Cohere param config and validation

## Changelog

### Added

- ✨Streaming Chat Workflow #149 #163 #161 (@roma-glushko)
- ✨Streaming Support for Azure OpenAI #173 (@mkrueger12)
- ✨Cohere Streaming Chat Support #171 (@mkrueger12)
- ✨Start counting token usage in Anthropic Chat #183 (@roma-glushko)
- ✨Handle unauthorized error in health tracker #170 (@roma-glushko)
- 🔧 #195 #196: Set router ctx in stream chunks & handle end of stream in case of some errors (@roma-glushko)
- 🐛🔧 #197: Handle max_tokens & content_filtered finish reasons across OpenAI, Azure and Cohere (@roma-glushko)

## Changed

- 🔧 💥 #198: Expose more Cohere params & fixing validation of provider params in config (breaking change) (@roma-glushko)
- 🔧 #186: Rendering Durations in a human-friendly way (@roma-glushko)

### Fixed

- 🐛 Fix Anthropic API key header #183 (@roma-glushko)
- 🐛 #209: Embed Swagger specs into binary to fix panics caused by missing swagger.yaml file (@roma-glushko)
- 🐛 #200: Implemented a custom json per line stream reader to read Cohere chat streams correctly (@roma-glushko)

### Security

-  🔓 Update crypto lib, golang, fiber #148 (@roma-glushko)

### Miscellaneous

-  🐛 Update README.md to fix helm chart location #167 (@arjunnair22)
- 🔧 Updated .go-version (@roma-glushko)
-  ✅ Covered the telemetry by tests #146 (@roma-glushko)
- 📝 Separate and list all supported capabilities per provider #190 (@roma-glushko)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roma-glushko roma-glushko

Labels
api:http good first issue Good for newcomers help wanted Extra attention is needed model:language provider:cohere size:small type:breaking 💥 Introduces a breaking changes to API, configuration or behavior introduced before type:enhancement New feature or request
Projects
None yet
Milestone
Glide: Public Preview
Development

Successfully merging a pull request may close this issue.

🔧 💥 #198: Expose more Cohere params EinStack/glide
1 participant
@roma-glushko