-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rn71 prep #4286
Merged
Merged
rn71 prep #4286
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
1548fc7
Upgrade the Android google-services plugin
swansontec 295481d
Upgrade to @bugsnag/react-native v7.20.2
swansontec ef49f13
Upgrade to @react-native-community/datetimepicker v7.2.0
swansontec 22eb503
Upgrade to readable-stream v3.6.2
swansontec 4175dce
Upgrade to react-native-popup-menu v0.16.1
swansontec 0b78ef8
Upgrade to react-native-reanimated v2.17.0
swansontec 60800df
Upgrade to react-native-webview v13.2.2
swansontec b95c96b
Fix the `Alert` style caching
swansontec 86d195c
Fix `AddressTile` event-subscription logic
swansontec 20626f7
Port AddressTile2 to hooks
swansontec beb138e
Fix various small type errors
swansontec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 0 additions & 40 deletions
40
patches/@react-native-community+datetimepicker+6.1.3.patch
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| diff --git a/node_modules/react-native-reanimated/react-native-reanimated.d.ts b/node_modules/react-native-reanimated/react-native-reanimated.d.ts | ||
| index c33d830..75f094f 100644 | ||
| --- a/node_modules/react-native-reanimated/react-native-reanimated.d.ts | ||
| +++ b/node_modules/react-native-reanimated/react-native-reanimated.d.ts | ||
| @@ -129,6 +129,7 @@ declare module 'react-native-reanimated' { | ||
| export type TransformStyleTypes = TransformsStyle['transform'] extends | ||
| | readonly (infer T)[] | ||
| | undefined | ||
| + | string | ||
| ? T | ||
| : never; | ||
| export type AdaptTransforms<T> = { | ||
| @@ -138,7 +139,7 @@ declare module 'react-native-reanimated' { | ||
|
|
||
| export type AnimateStyle<S> = { | ||
| [K in keyof S]: K extends 'transform' | ||
| - ? AnimatedTransform | ||
| + ? AnimatedTransform | string | ||
| : S[K] extends ReadonlyArray<any> | ||
| ? ReadonlyArray<AnimateStyle<S[K][0]>> | ||
| : S[K] extends object | ||
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| diff --git a/node_modules/react-native-webview/android/src/main/java/com/reactnativecommunity/webview/RNCWebViewModuleImpl.java b/node_modules/react-native-webview/android/src/main/java/com/reactnativecommunity/webview/RNCWebViewModuleImpl.java | ||
| index d5f3533..6e88590 100644 | ||
| --- a/node_modules/react-native-webview/android/src/main/java/com/reactnativecommunity/webview/RNCWebViewModuleImpl.java | ||
| +++ b/node_modules/react-native-webview/android/src/main/java/com/reactnativecommunity/webview/RNCWebViewModuleImpl.java | ||
| @@ -325,10 +325,6 @@ public class RNCWebViewModuleImpl implements ActivityEventListener { | ||
|
|
||
| public boolean grantFileDownloaderPermissions(String downloadingMessage, String lackPermissionToDownloadMessage) { | ||
| Activity activity = mContext.getCurrentActivity(); | ||
| - // Permission not required for Android Q and above | ||
| - if (Build.VERSION.SDK_INT > Build.VERSION_CODES.P) { | ||
| - return true; | ||
| - } | ||
|
|
||
| boolean result = ContextCompat.checkSelfPermission(activity, Manifest.permission.WRITE_EXTERNAL_STORAGE) == PackageManager.PERMISSION_GRANTED; | ||
| if (!result && Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) { | ||
| diff --git a/node_modules/react-native-webview/lib/WebViewShared.js b/node_modules/react-native-webview/lib/WebViewShared.js | ||
| index 347e915..167692f 100644 | ||
| --- a/node_modules/react-native-webview/lib/WebViewShared.js | ||
| +++ b/node_modules/react-native-webview/lib/WebViewShared.js | ||
| @@ -17,7 +17,7 @@ var extractOrigin = function (url) { | ||
| return result === null ? '' : result[0]; | ||
| }; | ||
| var originWhitelistToRegex = function (originWhitelist) { | ||
| - return "^".concat(escapeStringRegexp(originWhitelist).replace(/\\\*/g, '.*')); | ||
| + return "^" + escapeStringRegexp(originWhitelist).replace(/\\\*/g, '.*') + "$"; | ||
| }; | ||
| var passesWhitelist = function (compiledWhitelist, url) { | ||
| var origin = extractOrigin(url); | ||
| diff --git a/node_modules/react-native-webview/src/WebViewShared.tsx b/node_modules/react-native-webview/src/WebViewShared.tsx | ||
| index 7e4bc18..759bed8 100644 | ||
| --- a/node_modules/react-native-webview/src/WebViewShared.tsx | ||
| +++ b/node_modules/react-native-webview/src/WebViewShared.tsx | ||
| @@ -199,6 +199,8 @@ export const useWebViewLogic = ({ | ||
| } | ||
| // !patch for Android only | ||
| onLoadProgress?.(event); | ||
| + // @ts-expect-error | ||
| + updateNavigationState(event); | ||
| }, [onLoadProgress]); | ||
|
|
||
| const onShouldStartLoadWithRequest = useMemo(() => createOnShouldStartLoadWithRequest( |
8 changes: 4 additions & 4 deletions
8
patches/readable-stream+3.6.0.patch → patches/readable-stream+3.6.2.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| diff --git a/node_modules/readable-stream/lib/_stream_writable.js b/node_modules/readable-stream/lib/_stream_writable.js | ||
| index a2634d7..bfbcfea 100644 | ||
| index 292415e..a36257e 100644 | ||
| --- a/node_modules/readable-stream/lib/_stream_writable.js | ||
| +++ b/node_modules/readable-stream/lib/_stream_writable.js | ||
| @@ -466,7 +466,7 @@ function onwrite(stream, er) { | ||
| @@ -440,7 +440,7 @@ function onwrite(stream, er) { | ||
| function afterWrite(stream, state, finished, cb) { | ||
| if (!finished) onwriteDrain(stream, state); | ||
| state.pendingcb--; | ||
| - cb(); | ||
| + if (cb != null) cb(); | ||
| finishMaybe(stream, state); | ||
| } // Must force callback to be called on nextTick, so that we don't | ||
| // emit 'drain' before the write() consumer gets the 'false' return | ||
| } | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For context on this change: software-mansion/react-native-reanimated#4548 (comment)
Maybe I should stick that link into the commit message.