rn71 prep #4286
Merged
rn71 prep #4286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
commented
Jun 23, 2023
| export type TransformStyleTypes = TransformsStyle['transform'] extends | ||
| | readonly (infer T)[] | ||
| | undefined | ||
| + | string |
There was a problem hiding this comment.
For context on this change: software-mansion/react-native-reanimated#4548 (comment)
Maybe I should stick that link into the commit message.
paullinator
approved these changes
Jun 23, 2023
|
Approved but can you sanity check this on Android first before merge. |
See software-mansion/react-native-reanimated#4548 (comment) for information about this patch file.
This abuse of the `cacheStyles` function would have sent the styles over the bridge on every render. Instead, keep the common styles stable, and just apply the changing parts dynamically.
swansontec
force-pushed
the
william/rn71-prep
branch
from
742e194
to
beb138e
Compare
|
I did a clean Android build with this branch, and didn't run into any problems based on the current version of React Native. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
noneDependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: