This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
Add link markdown style in bio #7339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
medium
|
Welcome @harshpatel-r! Thank you so much for your first pull request! |
eddiejaoude
suggested changes
Jun 2, 2023
|
Hi @eddiejaoude , thank you for your feedback. Just to confirm, regarding the changes you mentioned, do you want me to: 1)Apply my styles globally to the Link component, or Could you please provide further guidance on how to proceed with this? |
|
Thanks @harshpatel-r , we would like to keep the current link style consistent, so option 2 please |
sync latest changes
github-actions
bot
added
small
|
Closes #7152 Changes Made:Updated the bio links style with the Link component. Screenshots
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
where the links in the bio were lacking the app's link styles (see screenshot) #7152
Closes #7152
Check List (Check all the applicable boxes)
Screenshots
fixed
Note to reviewers
@eddiejaoude @SaraJaoude
Please review and merge this pull request. It addresses the issue where the links in the bio were not displaying the app's link styles. To fix this problem, I have overridden the
<a>tag in react-markdown to ensure that the links in the bio have the correct styling.I have thoroughly tested the changes and verified that the links now appear with the desired app-specific styles. Additionally, I have ensured that the changes do not introduce any regressions and that all existing tests pass successfully.
Your feedback and review are greatly appreciated. Thank you for your time and assistance in merging these improvements!