Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

[BUG] links in bio with markdown do not have any visual identification #7152

Closed
eddiejaoude opened this issue May 24, 2023 · 14 comments · Fixed by #7339
Closed

[BUG] links in bio with markdown do not have any visual identification #7152

eddiejaoude opened this issue May 24, 2023 · 14 comments · Fixed by #7339
Assignees
Labels
💻 aspect: code undefined 🛠 goal: fix undefined good first issue undefined 🔢 points: 3 undefined 🟧 priority: high undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)

Comments

@eddiejaoude
Copy link
Member

eddiejaoude commented May 24, 2023

Description

Links in the bio with markdown work but they don't have our app's link styles on it

I believe in order to make this work, the <a> tag will need to be overridden in react-markdown

Suggested by Dan #7152 (comment)

Screenshots

No response

Additional information

No response

@eddiejaoude eddiejaoude added 💻 aspect: code undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) 🛠 goal: fix undefined good first issue undefined 🟧 priority: high undefined 🔢 points: 3 undefined labels May 24, 2023
@MAYANKpandey14
Copy link
Contributor

Can you provide some screenshots Eddie

@MAYANKpandey14
Copy link
Contributor

#7139 #7043 these issues conversations are locked . Kindly look into this.

@harshpatel-r
Copy link
Contributor

Hey folks,

I'm new to open source contributions, but I understand backend development well. Although my main expertise is in backend, I also have enough knowledge of front-end development to solve this problem. I see this as a valuable opportunity to contribute as a front-end developer.

Could you please assign this issue to me? Thanks!

@ChinmayMhatre
Copy link
Member

#7139 #7043 these issues conversations are locked . Kindly look into this.

I have unlocked these issues

@SaraJaoude
Copy link
Member

#7139 #7043 these issues conversations are locked . Kindly look into this.

I have unlocked these issues

@ChinmayMhatre thank you! I forgot to unlock when I changed the labels.

@dan-mba
Copy link
Member

dan-mba commented May 24, 2023

I believe in order to make this work, the <a> tag will need to be overridden in react-markdown

@codingsagar
Copy link

Please can you assign this issue to me. So that I start to work on this issue asap.
Thanks

@MAYANKpandey14
Copy link
Contributor

#7139 #7043 these issues conversations are locked . Kindly look into this.

I have unlocked these issues

Thank you Buddy @ChinmayMhatre

@badrivlog
Copy link
Contributor

#7139 #7043 these issues conversations are locked . Kindly look into this.

I have unlocked these issues

@ChinmayMhatre thank you! I forgot to unlock when I changed the labels.

@SaraJaoude kindly unlock #7142 this issue also

@KushagraVarshney05
Copy link
Contributor

@SaraJaoude @eddiejaoude I am new to opensource and would like to contribute. Can you assign this issue to me and provide some more details of this issue?

@SaraJaoude
Copy link
Member

Hey folks,

I'm new to open source contributions, but I understand backend development well. Although my main expertise is in backend, I also have enough knowledge of front-end development to solve this problem. I see this as a valuable opportunity to contribute as a front-end developer.

Could you please assign this issue to me? Thanks!

@harshpatel-r as you were the first to request this I have assigned it to you

@eddiejaoude
Copy link
Member Author

I believe in order to make this work, the <a> tag will need to be overridden in react-markdown

thanks @dan-mba I will add it to the issue description

@harshpatel-r
Copy link
Contributor

bio-link-style-fix

Hi @eddiejaoude @SaraJaoude ,
I hope you're doing well. I've been working on the issue where the links in the bio with markdown work but they don't have our app's link styles on it.

I have made progress in resolving this issue, but I'm uncertain about the specific color to use for the links. To ensure consistency with our app's design, could you kindly provide me with the preferred color code to apply to the links style?

Thank you very much for your assistance. I appreciate your help!

@eddiejaoude
Copy link
Member Author

I have made progress in resolving this issue, but I'm uncertain about the specific color to use for the links. To ensure consistency with our app's design, could you kindly provide me with the preferred color code to apply to the links style?

Great work @harshpatel-r !! Please can you use the Link component, then this will ensure consistency on the styles in the app now and in the future when we update the style https://github.com/EddieHubCommunity/LinkFree/blob/main/components/Link.js

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code undefined 🛠 goal: fix undefined good first issue undefined 🔢 points: 3 undefined 🟧 priority: high undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants