Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change testlist_clm ne30pg3_t061 tests to ne30pg3_t232 #2799

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

slevis-lmwg
Copy link
Contributor

Description of changes

Make this change to prevent failures reported in #2702.

Specific notes

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):
Fixes #2702

Are answers expected to change (and if so in what way)?
No.

Any User Interface Changes (namelist or namelist defaults changes)?
No.

Does this create a need to change or add documentation? Did you do so?
No.

Testing performed, if any:
None, yet.

@slevis-lmwg slevis-lmwg self-assigned this Sep 30, 2024
@slevis-lmwg slevis-lmwg added the bfb bit-for-bit label Sep 30, 2024
@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Sep 30, 2024

The failures reported in #2702 pass in ctsm checkouts.

With this PR's mods, I have submitted four tests, and I expect all four to pass:

PASS SMS_D_Ld1.ne30pg3_t061.I1850Clm50BgcSpinup.derecho_intel.clm-cplhist
PASS SMS_D_Ld1.ne30pg3_t232.I1850Clm50BgcSpinup.derecho_intel.clm-cplhist
PASS SMS_D_Ld1.ne30pg3_t061.I1850Clm50BgcSpinup.derecho_intel.clm-cplhist--clm-matrixcnOn
PASS SMS_D_Ld1.ne30pg3_t232.I1850Clm50BgcSpinup.derecho_intel.clm-cplhist--clm-matrixcnOn

@slevis-lmwg
Copy link
Contributor Author

@ekluzek I think this may complete the work in this PR. Let me know if you agree.

@slevis-lmwg slevis-lmwg marked this pull request as ready for review September 30, 2024 21:28
Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also change the C96 test and then looks great.

@slevis-lmwg slevis-lmwg merged commit 40fc188 into ESCOMP:b4b-dev Oct 1, 2024
2 checks passed
@slevis-lmwg slevis-lmwg deleted the change_t061_to_t232 branch October 1, 2024 00:39
@samsrabin samsrabin mentioned this pull request Oct 10, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants