Fix LILAC build with user-defined machine with latest CIME #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESMF_LIBDIR is deprecated; the preferred method for specifying the path to ESMF is now to use ESMFMKFILE. And the latter is needed for a check in the CMEPS buildnml; see also ESCOMP#1498
config_compilers.xml is deprecated; need a cmake macros file instead. Resolves ESCOMP#1492
|
I don't feel this needs a review. Since the files it touches are very limited, pretty clearly only impacting LILAC, I feel like it can come to master with only minimal testing. We can discuss briefly on Thursday. |
billsacks
added
the
next
billsacks
removed
the
next
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
With recent versions of CIME, the LILAC build with a user-defined machine was broken for a couple of reasons. This PR fixes it.
Specific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Testing performed, if any: