Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to update LILAC build process to use cmake macros instead of config_compilers.xml #1492

Closed
billsacks opened this issue Sep 17, 2021 · 6 comments · Fixed by #1571
Closed
Assignees
Labels
priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations

Comments

@billsacks
Copy link
Member

If I understand ESMCI/cime#4093 correctly, the LILAC build on a user-defined machine may stop working out of the box once that CIME PR is merged (though it may continue to work for some time depending on how backwards compatibility is implemented). To keep things working, rather than filling out a config_compilers.xml template, we'll instead need to fill out a cmake macros file.

Blocked: depends on ESMCI/cime#4093

@billsacks billsacks added priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations blocked: dependency Wait to work on this until dependency is resolved labels Sep 17, 2021
@ekluzek ekluzek added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Sep 23, 2021
@billsacks billsacks removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Sep 23, 2021
@billsacks billsacks removed the blocked: dependency Wait to work on this until dependency is resolved label Oct 7, 2021
@billsacks
Copy link
Member Author

ESMCI/cime#4093 has been merged, so this can come in when we do a cime update to that version.

@ekluzek
Copy link
Collaborator

ekluzek commented Nov 9, 2021

This comes with cime6.0.10 and the build for the LILACSMOKE test does break with cime6.0.11.

@ekluzek
Copy link
Collaborator

ekluzek commented Nov 9, 2021

Here's a log of the error in the atm_driver.bldlog

2021-11-08 20:38:37: MODEL_BUILD FAILED for test 'LILACSMOKE_D_Ld2.f10_f10_mg37.I2000Ctsm50NwpSpAsRs.cheyenne_intel.clm-lilac'.
Command: ./case.build --model-only
Output: WARNING: Found difference in test STOP_N: case: 2 original value 5
Setting resource.RLIMIT_STACK to -1 from (-1, -1)
Building test for LILACSMOKE in directory /glade/scratch/erik/tests_ctsm51d62acl/LILACSMOKE_D_Ld2.f10_f10_mg37.I2000Ctsm50NwpSpAsRs.cheyenne_intel.clm-lilac.GC.ctsm51d62acl_int
ERROR: Command: 'make COMPILER=intel DEBUG=TRUE CTSM_MKFILE=/glade/scratch/erik/tests_ctsm51d62acl/LILACSMOKE_D_Ld2.f10_f10_mg37.I2000Ctsm50NwpSpAsRs.cheyenne_intel.clm-lilac.GC.ctsm51d62acl_int/lilac_build/ctsm.mk atm_driver' failed with error 'See /glade/scratch/erik/tests_ctsm51d62acl/LILACSMOKE_D_Ld2.f10_f10_mg37.I2000Ctsm50NwpSpAsRs.cheyenne_intel.clm-lilac.GC.ctsm51d62acl_int/lilac_atm_driver/bld/atm_driver.bldlog' from dir '/glade/scratch/erik/tests_ctsm51d62acl/LILACSMOKE_D_Ld2.f10_f10_mg37.I2000Ctsm50NwpSpAsRs.cheyenne_intel.clm-lilac.GC.ctsm51d62acl_int/lilac_atm_driver/bld'

 ---------------------------------------------------
tests_ctsm51d62acl/LILACSMOKE_D_Ld2.f10_f10_mg37.I2000Ctsm50NwpSpAsRs.cheyenne_intel.clm-lilac.GC.ctsm51d62acl_int> cat /glade/scratch/erik/tests_ctsm51d62acl/LILACSMOKE_D_Ld2.f10_f10_mg37.I2000Ctsm50NwpSpAsRs.cheyenne_intel.clm-lilac.GC.ctsm51d62acl_int/lilac_atm_driver/bld/atm_driver.bldlog 
Makefile:19: Macros.make: No such file or directory
make: *** No rule to make target 'Macros.make'.  Stop.

@billsacks
Copy link
Member Author

I'll start working on this.

@billsacks billsacks self-assigned this Nov 9, 2021
@billsacks
Copy link
Member Author

FYI, the error above that @ekluzek ran into is somewhat separate from the initial issue I foresaw, though probably related: this error in the LILACSMOKE test arises because a Macros.make file is no longer generated in the case directory. I'll work on fixing that, too.

@billsacks
Copy link
Member Author

The issue @ekluzek raised is fixed in ekluzek#2 . I'll work on the initial issue with a user-defined machine next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants