MIMICS into vertically resolved CTSM #1318
Conversation
Added is_microbe to SoilBiogeochemDecompCascadeConType.F90 and copied SoilBiogeochemDecompCascadeBGCMod.F90 to SoilBiogeochemDecompCascadeMIMICSMod.F90 as a template for the work to be done. No modifications to this file in this commit.
Transforming SoilBiogeochemDecompCascadeBGCMod.F90 into SoilBiogeochemDecompCascadeMIMICSMod.F90. Setting up the framework that MIMICS will fit into by using hooks already present in the CTSM. I will post explanations and requests for clarification in the PR. This is NOT working code.
| @@ -0,0 +1,1302 @@ | |||
| module SoilBiogeochemDecompCascadeMIMICSMod | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
slevis-lmwg
added
PR status: work in progress
size: large
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Largely updating the comments. Partly also updating code.
Remove unnecessary settings of nextsw_cday Remove setting of nextsw_cday in initialization: this hasn't been needed ever since we stopped calculating albedos in initialization. Also remove nextsw_cday from clm_time_manager: this was being set but was never referenced from here: instead, nextsw_cday was being passed as an argument to clm_drv. Also, updates cime to a branch tag where I have fixed the --retry option to create_test.
|
@wwieder thanks! I will start the test-suites and will report when they complete. |
Resolved conflicts: doc/ChangeLog doc/ChangeSum
|
@ekluzek the code uses four new param files in |
izumi OK except one test fails cheyenne PASS I will update the ChangeLog with these test results and push. Then, I think this PR is ready unless the izumi_pgi test needs investigation. Also, pending my question above about rimporting the new param files. |
Remembered and added another issue that this PR resolves
|
The PGI test seems to only be roundoff. And as it's only difference in answers for one test (and it's PGI which seems to be more sensitive) I think it's reasonable to take this as being fine. SMS_Vmct.f10_f10_mg37.I2000Clm50BgcCrop.izumi_pgi.clm-crop |
|
Yes go ahead and rimport the files. I usually do this first, before running on izumi, so that the files will automatically appear their when you test. |
| <option name="wallclock">00:20:00</option> | ||
| <option name="comment" >Test soil_decomp_method = 'MIMICSWieder2015'</option> | ||
| </options> | ||
| </test> |
There was a problem hiding this comment.
- Add a test for 1x1_brazil for the newton_krylov_spinup to run say 1 year.
SMS_Ly5_Mmpi-serial.1x1_brazil.IHistClm50BgcQianRs.cheyenne_intel.clm-newton_krylov_spinup
|
New test completed successfully and new baseline created: @ekluzek I updated the ChangeLog to mention this. |
ekluzek
added
PR status: ready
… some description on them
|
Thanks Sam and Erik! |
samsrabin
added
enhancement
Description of changes
Adding new model of below-ground biogeochemistry to the CTSM.
Specific notes
Getting MIMICS from Wieder et al. 2015 and from testbed into the vertically resolved CTSM.
Related issue: #1260
Contributors other than yourself, if any:
@wwieder @ekluzek
CTSM Issues Fixed (include github issue #):
Fixes #1473
Are answers expected to change (and if so in what way)?
No when comparing to answers from CTSM's existing below-ground bgc model(s).
Any User Interface Changes (namelist or namelist defaults changes)?
soilbgc_decomp can now also be MIMICSWieder2015
Testing performed, if any: regular testing