decomp_depth_efolding appears (with the same value) in the namelist and the params files; the model ends up using the one from the namelist

[slevis-lmwg]

Brief summary of bug

decomp_depth_efolding appears (with the same value) in the namelist and the params files; the model ends up using the one from the namelist. I report this as a bug because users may wrongly believe that they can change the value of this parameter by updating the params files.

General bug information

CTSM version you are using:
ctsm5.1.dev053-48-g1c1a9451

Does this bug cause significantly incorrect results in the model's science? [Yes / No]
No, unless user thought that they were modifying the value via the params files.

Configurations affected:
Configurations using vertically resolved DecompCascadeBGC or DecompCascadeCN (deprecated) for below-ground decomposition.

Details of bug

Summary gives enough detail.
To correct, @slevisconsulting will remove decomp_depth_efolding from the namelist.

[wwieder]

@ekluzek, @olyson, or @djk2120 is this corrected on the PPE branch?

[djk2120]

We didn't change anything. I just switched to using the namelist for perturbations instead of the paramfile.

…

On Thu, Nov 4, 2021 at 9:22 AM will wieder ***@***.***> wrote: @ekluzek <https://github.com/ekluzek>, @olyson <https://github.com/olyson>, or @djk2120 <https://github.com/djk2120> is this corrected on the PPE branch? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1473 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADNHR5QFFT6U6XVUL2OH5DDUKK6OJANCNFSM5DCISJ2A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[dlawrenncar]

Seems like we should fix this somehow to avoid future errors. Maybe the best in the long run would be to remove teh namelist option and use what's on parameter file, to be more consistent with what we do with most parameters.

…

On Thu, Nov 4, 2021 at 10:46 AM djk2120 ***@***.***> wrote: We didn't change anything. I just switched to using the namelist for perturbations instead of the paramfile. On Thu, Nov 4, 2021 at 9:22 AM will wieder ***@***.***> wrote: > @ekluzek <https://github.com/ekluzek>, @olyson < https://github.com/olyson>, > or @djk2120 <https://github.com/djk2120> is this corrected on the PPE > branch? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#1473 (comment)>, or > unsubscribe > < https://github.com/notifications/unsubscribe-auth/ADNHR5QFFT6U6XVUL2OH5DDUKK6OJANCNFSM5DCISJ2A > > . > Triage notifications on the go with GitHub Mobile for iOS > < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 > > or Android > < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub >. > > — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1473 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFABYVGB27Z4XRZAYUUCMN3UKK2F7ANCNFSM5DCISJ2A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[wwieder]

@olyson can you update this on the PPE branch, then we can merge to master?

[olyson]

@ekluzek how would you like me to handle this? Branch off of latest master? I think you've been managing the PPE branch.

[wwieder]

oh, maybe we can just make the change on main, that's where the change actually could come it. it should be a simple bfb change?

[olyson]

It should be bfb. Looking at the issue, it seemed like Sam had already done this on the mimics branch? When does that come to main?

[dlawrenncar]

If it is on mimics branch already, seems like we can just wait and let this get sorted with mimics comes on.

…

On Thu, Nov 4, 2021 at 12:56 PM Keith Oleson ***@***.***> wrote: It should be bfb. Looking at the issue, it seemed like Sam had already done this on the mimics branch? When does that come to main? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1473 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFABYVFYIHLLH7EJTEMA33DUKLQPRANCNFSM5DCISJ2A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[wwieder]

Makes sense, without a real need to push for 'release' of CTSM5.1 we can let this get fixed with #1318