Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two answer changes turn dribble_crophrv_xsmrpool_2atm and correct clm5_1 finidat file for 2000 conditions #1177

Merged
merged 4 commits into from
Oct 7, 2020

Conversation

ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Oct 7, 2020

Description of changes

Turn dribble_crophrv_xsmrpool_2atm when crop is on for clm4_5, clm5_0, and clm5_1 physics
Fix the finidat files being selected for 2000_control conditions for clm5_1

Specific notes

Contributors other than yourself, if any: self

CTSM Issues Fixed (include github issue #):

Fixes #1158
Another issue in #1166

Are answers expected to change (and if so in what way)? Yes (for all crop compsets and 2000Clm51 compsets)

Any User Interface Changes (namelist or namelist defaults changes)? N

Testing performed, if any: ran build-namelist unit tester, now running regular test suite

@ekluzek ekluzek self-assigned this Oct 7, 2020
@ekluzek ekluzek added PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete tag: bug - impacts science labels Oct 7, 2020
@ekluzek ekluzek changed the title Two answer changes turn Two answer changes turn dribble_crophrv_xsmrpool_2atm and correct clm5_1 finidat file for 2000 conditions Oct 7, 2020
@ekluzek
Copy link
Collaborator Author

ekluzek commented Oct 7, 2020

This has passed testing as expected. The changes to answers are for clm4_5/clm5_0 BgcCrop tests and clm5_1 2000 (or HIST compsets with DecStart).

@ekluzek ekluzek merged commit d3c31a3 into ESCOMP:master Oct 7, 2020
@ekluzek ekluzek deleted the dribble_n_clm512000 branch October 7, 2020 17:50
@samsrabin samsrabin added bug something is working incorrectly science Enhancement to or bug impacting science labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is working incorrectly PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete science Enhancement to or bug impacting science
Projects
None yet
Development

Successfully merging this pull request may close these issues.

turn off requirement for prognostic CO2 for using dribble_crophrv_xsmrpool_2atm?
2 participants