Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn off requirement for prognostic CO2 for using dribble_crophrv_xsmrpool_2atm? #1158

Closed
wwieder opened this issue Sep 22, 2020 · 3 comments · Fixed by #1177
Closed

turn off requirement for prognostic CO2 for using dribble_crophrv_xsmrpool_2atm? #1158

wwieder opened this issue Sep 22, 2020 · 3 comments · Fixed by #1177
Assignees
Labels
bug something is working incorrectly science Enhancement to or bug impacting science
Milestone

Comments

@wwieder
Copy link
Contributor

wwieder commented Sep 22, 2020

My understanding is that the xsmr harvest bug fix (#590 & #610) is still only on when using crop and prognostic CO2?

<dribble_crophrv_xsmrpool_2atm co2_type="prognostic" use_crop=".true.">.true.</dribble_crophrv_xsmrpool_2atm>

Can we remove the prognostic CO2 conditional in CTSM5.1? Should the same be done for CESM2.2?

@ekluzek
Copy link
Collaborator

ekluzek commented Sep 22, 2020

Yes, this is on only when co2_type="prognostic" for clm4_5 or clm5_0. This could be changed for clm5_1, so that it's always on when crop is on.

The xml should look something like...

<dribble_crophrv_xsmrpool_2atm phys="clm5_1"                use_crop=".true.">.true.</dribble_crophrv_xsmrpool_2atm>
<dribble_crophrv_xsmrpool_2atm co2_type="prognostic" use_crop=".true.">.true.</dribble_crophrv_xsmrpool_2atm>
<dribble_crophrv_xsmrpool_2atm                                         use_crop=".true.">.false.</dribble_crophrv_xsmrpool_2atm>

And phys needs to be added to the CLMBuildNamelist.pm. It could be turned on for all versions if that's what we really want. I think it makes sense to keep the previous behavior for clm5_0 though. But, let me know if we don't want that.

@wwieder
Copy link
Contributor Author

wwieder commented Sep 22, 2020 via email

@ekluzek ekluzek added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Sep 24, 2020
@billsacks billsacks added bug something is working incorrectly and removed next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Sep 24, 2020
@billsacks
Copy link
Member

@dlawrenncar says we should change this for older physics versions, too (clm5_0 and clm4_5). And in that case, we should just go ahead and remove this namelist item.

ekluzek added a commit to ekluzek/CTSM that referenced this issue Oct 7, 2020
@samsrabin samsrabin added the science Enhancement to or bug impacting science label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is working incorrectly science Enhancement to or bug impacting science
Projects
None yet
5 participants