Skip to content

Expand the IRI of @id in the dict returned by load_dict()#342

Closed
jesper-friis wants to merge 2 commits intomasterfrom
expanded_iri
Closed

Expand the IRI of @id in the dict returned by load_dict()#342
jesper-friis wants to merge 2 commits intomasterfrom
expanded_iri

Conversation

@jesper-friis
Copy link
Contributor

Description

Expand the IRI of @id in the dict returned by load_dict().

This is a behaviour change. Is it really what we want? An alternative would be to add an option expand_iri=False.

Applied on top of #340. Ensures that the sparql query works.

Type of change

  • Bug fix and code cleanup
  • New feature
  • Documentation update
  • Testing

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?
  • Is the code properly tested?

@codecov
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.76%. Comparing base (060c3a4) to head (1a964a0).
Report is 96 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #342   +/-   ##
=======================================
  Coverage   76.75%   76.76%           
=======================================
  Files          22       22           
  Lines        2512     2513    +1     
=======================================
+ Hits         1928     1929    +1     
  Misses        584      584           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jesper-friis jesper-friis mentioned this pull request Feb 19, 2025
10 tasks
@jesper-friis jesper-friis linked an issue Feb 19, 2025 that may be closed by this pull request
Base automatically changed from flb/expand_iri_in_sparql_query to master February 27, 2025 14:17
@francescalb
Copy link
Contributor

On further consideration I think we are tackling this from the wrong angle. We should not expand the iri that we fetch, as we do not know what the original prefix called for. However, we should expand the iri when we upload the documentation to the database.

@jesper-friis
Copy link
Contributor Author

On further consideration I think we are tackling this from the wrong angle. We should not expand the iri that we fetch, as we do not know what the original prefix called for. However, we should expand the iri when we upload the documentation to the database.

I agree

@jesper-friis
Copy link
Contributor Author

I think that this PR is outdated. The dict returned by the get_dict() function now has all keys expanded to full IRIs.

@Francesca, ok for you to close this PR?

@jesper-friis jesper-friis deleted the expanded_iri branch April 23, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attrdict return non-expanded iris, is this correct?

2 participants