Expand the IRI of @id in the dict returned by load_dict()#342
Expand the IRI of @id in the dict returned by load_dict()#342jesper-friis wants to merge 2 commits intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #342 +/- ##
=======================================
Coverage 76.75% 76.76%
=======================================
Files 22 22
Lines 2512 2513 +1
=======================================
+ Hits 1928 1929 +1
Misses 584 584 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
On further consideration I think we are tackling this from the wrong angle. We should not expand the iri that we fetch, as we do not know what the original prefix called for. However, we should expand the iri when we upload the documentation to the database. |
I agree |
|
I think that this PR is outdated. The dict returned by the @Francesca, ok for you to close this PR? |
Description
Expand the IRI of @id in the dict returned by load_dict().
This is a behaviour change. Is it really what we want? An alternative would be to add an option
expand_iri=False.Applied on top of #340. Ensures that the sparql query works.
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.