Skip to content

Flb/expand iri in sparql query#340

Merged
francescalb merged 4 commits intomasterfrom
flb/expand_iri_in_sparql_query
Feb 27, 2025
Merged

Flb/expand iri in sparql query#340
francescalb merged 4 commits intomasterfrom
flb/expand_iri_in_sparql_query

Conversation

@francescalb
Copy link
Contributor

Description

Type of change

  • Bug fix and code cleanup
  • New feature
  • Documentation update
  • Testing

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?
  • Is the code properly tested?

@codecov
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.75%. Comparing base (64603f5) to head (8f6881f).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
+ Coverage   76.60%   76.75%   +0.14%     
==========================================
  Files          22       22              
  Lines        2509     2512       +3     
==========================================
+ Hits         1922     1928       +6     
+ Misses        587      584       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved since the failing test_sparqlwrapper_graphdb test is fixed by PR #342 .

Comment on lines +152 to +153
print(retreived_info)
print(retreived_info_2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be removed

Copy link
Contributor

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but check the comment

@francescalb francescalb merged commit 060c3a4 into master Feb 27, 2025
19 checks passed
@francescalb francescalb deleted the flb/expand_iri_in_sparql_query branch February 27, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants