Merged
Conversation
Codecov ReportBase: 80.76% // Head: 81.20% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #222 +/- ##
==========================================
+ Coverage 80.76% 81.20% +0.44%
==========================================
Files 39 41 +2
Lines 1102 1128 +26
==========================================
+ Hits 890 916 +26
Misses 212 212
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
8 tasks
CasperWA
requested changes
Jan 10, 2023
Contributor
CasperWA
left a comment
CasperWA
left a comment
There was a problem hiding this comment.
An initial review. As discussed in the meeting, there are some things I need to test locally and then I'll come back with a full review :)
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
…SBL/oteapi-core into enh/secrets-json-encoders
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
CasperWA
reviewed
Jan 24, 2023
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
CasperWA
approved these changes
Jan 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Type of change:
Checklist for the reviewer:
This checklist should be used as a help for the reviewer.
@CasperWA, please see the new
SecretConfigand the related encoding in the pydanticConfig, which allows the optional exposing of secrets when it needs to be serialized, e.g. for the RedisCache in ote-services.