GA4GHTT-261 - 44 1 #242
Closed
GA4GHTT-261 - 44 1 #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcezard
reviewed
Apr 26, 2024
src/vcf/record.cpp
Outdated
| @@ -704,7 +776,7 @@ namespace ebi | |||
| } | |||
| if(!values.empty()) { | |||
| if (values.front() == MISSING_VALUE) { return; } // No need to check missing data | |||
| } | |||
| } //TODO, if the 1st one is . then check stops; is that correct? svclaim=.,DJ worked! | |||
There was a problem hiding this comment.
This is not correct indeed:
SVCLAIM=.
Is correct because missing value applies to all value
SVCLAIM=.,DJ
Needs to be checked for cardinality
|
taken care in PR #246. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-To share the changes made so far-
4.4 updated with changes for CN, SVCLAIM, SVLEN.
Newly added test files (CNV.vcf) are processed as required.
test_validator_v44 runs fine, test_validation_suit fails and needs further update.
Test code for changes to be updated.