Update latest from dev #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump to 2.4.2
Fix audio wave not rendered after completion
Improve the rendering speed, especially when zoomed very close. Additionally, when zoomed further out, there are now two plots displayed: the max values and the average values. There are some ideas to easily extend and improve this further on the library side; See comments
Improve waveform display rendering
Keep the users name when duplicating a title; Increment number if existing; add if not yet existing
Fix secondsToZoom to work correctly for exact matches
Improve Title duplication counting
The .png icon was 64x56, oddly. Re-exported from inkscape at 64x64.
Hinting for applications consuming the metadata, which might influence whether/which images are downloaded and displayed.
* Name tag should match `Name=` field in `.desktop` * `GPL-3.0-or-later` is apparently the accepted form now[1] [1]: https://spdx.org/licenses/
This one's purely YMMV. The description seemed a little spare, and didn't really fit the recommendations[1], e.g: * Include 2-3 paragraphs of interesting easy to read prose. * Ensure you provide a description of what the application actually does. * Describe any important features. So I borrowed ours, which was cribbed from the `.desktop` file. [1]: https://www.freedesktop.org/software/appstream/docs/chap-Quickstart.html#sect-Quickstart-DesktopApps
Square the PNG icon file
Appdata updates
Youtube supports upload of video at any frame rate.[1] Given OpenShot's sensitivity to framerate changes, it doesn't make sense that the YouTube-HD preset only offers 25fps and 29.97fps choices for Video Profile. This change adds in 23.978fps, 24fps, and 30fps options for both 720p and 1080p. I wanted to add the higher frame rates as well (50, 59.94, and 60 fps), but the "High" bitrate setting of 8Mbps doesn't meet their recommended bitrate of 12Mbps for 1080p video at those rates[1], and there's currently no way to make export bitrate dependent on frame rate. Given its increasing popularity, though, a separate "YouTube-60fps" preset with higher video bitrates might be warranted. [1]: https://support.google.com/youtube/answer/1722171
Like YouTube, Vimeo accepts video at any frame rate.[1] So, this makes the same change as the previous commit, adding additional frame rates <= 30fps. However, Vimeo's recommended bitrate is 10-20Mbps for 1080p video[1], so the video bitrate bins also get tweaked from 2/5/8 Mbps to 4/8/12 Mbps. [1]: https://vimeo.com/help/compression
To reduce the size of the icon SVG, I... * Brought it into Inkscape, let it adjust the DPI, and then saved it as a Plain SVG (rather than an Inkscape SVG), which removed a bunch of inkscape-specific tags/attributes that only serve to bloat the file. * Hand-edited the output to remove an Illustrator `<foreignobject>` definition that Inkscape can't process, as well as a _giant_ chunk of Illustrator metadata (`<i:pgf>` tag) that was hanging around. **File size change:** 629 KB => 183 KB **Visible differences:** None, also see below. **Differences in exported PNG:** None. I exported a 64x64 PNG from the updated .SVG file and ran an image-diff with ImageMagick `compare`. It produced a completely empty image.
Gnome just released 3.30, and with it some [new Design Guidelines][1] to prepare for 3.32 (when they'll go into effect). One of them is a new requirement that applications provide a 256x256 pixel icon for their application, to go along with the previous 48x48 icon. (OpenShot has been shipping a 64x64 icon, which is fine as it gets scaled down when necessary.) Since scaling the 64x64 icon _up_ to 256x256 looks **horrible**, this change adds `xdg/openshot-qt_256.png` to the repo, exported from the scalable SVG source just like the 64x64 icon. [1]: https://help.gnome.org/misc/release-notes/3.30/developers.html.en#design-guidelines
Gnome also recommends a 512x512 pixel variant of the application icon, for HiDPI displays.
`setup.py` can't rename files during the install process, according to its docs, so the icon files all need to be named `openshot-qt.png` as that'll be their destination name. Achieve this by putting them all in a directory hierarchy named by size.
The `setup.py` installer in the repo root directory has only been installing the SVG icon file, and into `/usr/share/pixmaps/` which is a path only used by the Debian menu system[1] (not by XDG, as the file claims.) XDG uses Freedesktop's icon theme specification[2], which instructs application developers to install their icon files in the theme directories: `$prefix/share/icons/hicolor/*/apps` (sorted by size). This change installs the existing `openshot-qt.svg` scalable icon and `openshot-qt.png` (64x64) icon, as well as the new 256x256 and 512x512 PNGs, into their appropriate places in the icon theme hierarchy. Again, this is something we've been taking care of "manually" on the packaging end. I'd prefer to offload it to `setup.py`, which we're running anyway as part of the package-build process, so that everyone building the package can benefit from it. [1]: https://www.debian.org/doc/packaging-manuals/menu.html/ch3.html#s3.7 [2]: https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#install_icons
Completely remove the old src/locale dir
…t look so official on the website
…lti-selection on the timeline.
… and QRC file. This is the first language translation update after our new language code has been merged.
…g.py) back to the release branch
… transition crashing)
Release of 2.4.3 (Merge release branch into master branch)
Merge master into develop (2.4.3 release)
Simplify version number and file name logic in build server
Update appdata
* No bare value logging (always labeled) * No redundant parameter logging * Same log format in all _changed() slots
Instead of logging on _every_ pass through the blender-output scan, only log if an output frame is actually detected. Cuts per-frame output spam by ~ 95%
title_editor.py: Don't import unused QWebView
Blender logging cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.