Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blender logging cleanup #2159

Merged
merged 5 commits into from
Oct 2, 2018
Merged

Blender logging cleanup #2159

merged 5 commits into from
Oct 2, 2018

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Sep 27, 2018

A bunch of changes to clean up the logging in blender_listview.py.

  • No more bare-value logging
    • e.g. log.info(value), log.info(final_path)
    • All log lines contain some explanatory label
  • Eliminate redundant logging of same value in multiple places
  • All editable parameter slots use the same log format (taken from color_button_clicked()): 
    # On slot entry
log.info('Animation param being changed: %s' % param["name"])
# On processing of parameter argument
log.info('New value of param: %s' % value)
  • Instead of logging every time through the blender-output loop, only log when an output filename is detected. On my system this cuts some 20+ lines per frame that all contained: 
    blender_listview:INFO Image detected from blender regex: []

End result, the logging from an Animated Title session will look like this

New log output. 
blender_model:INFO updating effects model.
blender_listview:INFO Using parameter file_name: File Name
blender_listview:INFO Using parameter title: Title
blender_listview:INFO Using parameter extrude: Extrude
blender_listview:INFO Using parameter bevel_depth: Bevel Depth
blender_listview:INFO Using parameter fontname: Font Name
blender_listview:INFO Animation param being changed: fontname
blender_listview:INFO New value of param: Bfont
blender_listview:INFO Using parameter spacemode: Text Alignment
blender_listview:INFO Animation param being changed: spacemode
blender_listview:INFO New value of param: CENTER
blender_listview:INFO Using parameter text_size: Text Size
blender_listview:INFO Using parameter width: Text Width
blender_listview:INFO Using parameter diffuse_color: Diffuse Color
blender_listview:INFO Using parameter specular_color: Specular Color
blender_listview:INFO Using parameter specular_intensity: Specular Intensity
blender_listview:INFO Using parameter use_alpha: Use Alpha
blender_listview:INFO Animation param being changed: use_alpha
blender_listview:INFO New value of param: No
blender_listview:INFO Animation param being changed: use_alpha
blender_listview:INFO New value of param: Yes
blender_listview:INFO Using parameter start_frame: Start Frame
blender_listview:INFO Using parameter end_frame: End Frame
blender_listview:INFO Using parameter animation_speed: Animation Length
blender_listview:INFO Animation param being changed: animation_speed
blender_listview:INFO New value of param: 2
blender_listview:INFO Animation param being changed: animation_speed
blender_listview:INFO New value of param: 1
blender_listview:INFO init_slider_values
blender_listview:INFO sliderPreview_valueChanged: 1
blender_listview:INFO sliderPreview_valueChanged: 60
blender_listview:INFO btnRefresh_clicked
blender_listview:INFO QThread Render Method Invoked
blender_listview:INFO preview_timer_onTimeout
blender_listview:INFO Blender command: blender -b '/home/ferd/rpmbuild/REPOS/openshot-qt/src/blender/blend/zoom_clapboard.blend' -P '/home/ferd/.openshot_qt/blender/d7676cda-c209-11e8-866b-2c27d72bd51f/zoom_clapboard.py'
blender_listview:INFO Image detected from blender regex: [('/home/ferd/.openshot_qt/blender/d7676cda-c209-11e8-866b-2c27d72bd51f/TitleFileName0060.png', '')]
blender_listview:INFO Blender render thread finished
blender_listview:INFO onRenableInterface
blender_listview:INFO QThread Render Method Invoked
blender_listview:INFO Blender command: blender -b '/home/ferd/rpmbuild/REPOS/openshot-qt/src/blender/blend/zoom_clapboard.blend' -P '/home/ferd/.openshot_qt/blender/d7676cda-c209-11e8-866b-2c27d72bd51f/zoom_clapboard.py'
blender_listview:INFO Image detected from blender regex: [('/home/ferd/.openshot_qt/blender/d7676cda-c209-11e8-866b-2c27d72bd51f/TitleFileName0060.png', '')]
blender_listview:INFO Blender render thread finished
blender_listview:INFO onRenableInterface
blender_listview:INFO Animation param being changed: extrude
blender_listview:INFO New value of param: 0.11
blender_listview:INFO Animation param being changed: extrude
blender_listview:INFO New value of param: 0.12
blender_listview:INFO Animation param being changed: text_size
blender_listview:INFO New value of param: 1.01
blender_listview:INFO Animation param being changed: text_size
blender_listview:INFO New value of param: 1.02
blender_listview:INFO Animation param being changed: text_size
blender_listview:INFO New value of param: 1.03
blender_listview:INFO Animation param being changed: text_size
blender_listview:INFO New value of param: 1.04
blender_listview:INFO Animation param being changed: text_size
blender_listview:INFO New value of param: 1.05
blender_listview:INFO Animation param being changed: spacemode
blender_listview:INFO New value of param: LEFT
blender_listview:INFO Animation param being changed: title
blender_listview:INFO New value of param:  Title
blender_listview:INFO Animation param being changed: title
blender_listview:INFO New value of param: Title
blender_listview:INFO QThread Render Method Invoked
blender_listview:INFO Blender command: blender -b '/home/ferd/rpmbuild/REPOS/openshot-qt/src/blender/blend/zoom_clapboard.blend' -P '/home/ferd/.openshot_qt/blender/d7676cda-c209-11e8-866b-2c27d72bd51f/zoom_clapboard.py'
blender_listview:INFO sliderPreview_valueChanged: 1
blender_listview:INFO Image detected from blender regex: [('/home/ferd/.openshot_qt/blender/d7676cda-c209-11e8-866b-2c27d72bd51f/TitleFileName0001.png', '')]
blender_listview:INFO sliderPreview_valueChanged: 2
blender_listview:INFO Image detected from blender regex: [('/home/ferd/.openshot_qt/blender/d7676cda-c209-11e8-866b-2c27d72bd51f/TitleFileName0002.png', '')]
blender_listview:INFO sliderPreview_valueChanged: 3
blender_listview:INFO Image detected from blender regex: [('/home/ferd/.openshot_qt/blender/d7676cda-c209-11e8-866b-2c27d72bd51f/TitleFileName0003.png', '')]
blender_listview:INFO sliderPreview_valueChanged: 4
blender_listview:INFO Image detected from blender regex: [('/home/ferd/.openshot_qt/blender/d7676cda-c209-11e8-866b-2c27d72bd51f/TitleFileName0004.png', '')]
blender_listview:INFO sliderPreview_valueChanged: 5
blender_listview:INFO Image detected from blender regex: [('/home/ferd/.openshot_qt/blender/d7676cda-c209-11e8-866b-2c27d72bd51f/TitleFileName0005.png', '')]

Whereas before, a roughly-equivalent session would log all this

Old log output. 
blender_model:INFO updating effects model.
blender_listview:INFO File Name
blender_listview:INFO Title
blender_listview:INFO Extrude
blender_listview:INFO Bevel Depth
blender_listview:INFO Font Name
blender_listview:INFO Bfont
blender_listview:INFO Text Alignment
blender_listview:INFO CENTER
blender_listview:INFO Text Size
blender_listview:INFO Text Width
blender_listview:INFO Diffuse Color
blender_listview:INFO Specular Color
blender_listview:INFO Specular Intensity
blender_listview:INFO Use Alpha
blender_listview:INFO No
blender_listview:INFO Yes
blender_listview:INFO Start Frame
blender_listview:INFO End Frame
blender_listview:INFO Animation Length
blender_listview:INFO 2
blender_listview:INFO 1
blender_listview:INFO init_slider_values
blender_listview:INFO sliderPreview_valueChanged: 1
blender_listview:INFO sliderPreview_valueChanged: 60
blender_listview:INFO btnRefresh_clicked
blender_listview:INFO QThread Render Method Invoked
blender_listview:INFO preview_timer_onTimeout
blender_listview:INFO Blender command: blender -b '/home/ferd/.local/lib/python3.6/site-packages/openshot_qt-2.4.3-py3.6.egg/openshot_qt/blender/blend/zoom_clapboard.blend' -P '/home/ferd/.openshot_qt/blender/73885a08-c209-11e8-9996-2c27d72bd51f/zoom_clapboard.py'
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: [('/home/ferd/.openshot_qt/blender/73885a08-c209-11e8-9996-2c27d72bd51f/TitleFileName0060.png', '')]
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Blender render thread finished
blender_listview:INFO onRenableInterface
blender_listview:INFO QThread Render Method Invoked
blender_listview:INFO Blender command: blender -b '/home/ferd/.local/lib/python3.6/site-packages/openshot_qt-2.4.3-py3.6.egg/openshot_qt/blender/blend/zoom_clapboard.blend' -P '/home/ferd/.openshot_qt/blender/73885a08-c209-11e8-9996-2c27d72bd51f/zoom_clapboard.py'
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: [('/home/ferd/.openshot_qt/blender/73885a08-c209-11e8-9996-2c27d72bd51f/TitleFileName0060.png', '')]
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Blender render thread finished
blender_listview:INFO onRenableInterface
blender_listview:INFO 0.11
blender_listview:INFO 0.12
blender_listview:INFO 0.13
blender_listview:INFO 0.14
blender_listview:INFO 0.15000000000000002
blender_listview:INFO LEFT
blender_listview:INFO T
blender_listview:INFO Ti
blender_listview:INFO Tit
blender_listview:INFO Titl
blender_listview:INFO Title
blender_listview:INFO QThread Render Method Invoked
blender_listview:INFO Blender command: blender -b '/home/ferd/.local/lib/python3.6/site-packages/openshot_qt-2.4.3-py3.6.egg/openshot_qt/blender/blend/zoom_clapboard.blend' -P '/home/ferd/.openshot_qt/blender/73885a08-c209-11e8-9996-2c27d72bd51f/zoom_clapboard.py'
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO sliderPreview_valueChanged: 1
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: [('/home/ferd/.openshot_qt/blender/73885a08-c209-11e8-9996-2c27d72bd51f/TitleFileName0001.png', '')]
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO sliderPreview_valueChanged: 2
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: [('/home/ferd/.openshot_qt/blender/73885a08-c209-11e8-9996-2c27d72bd51f/TitleFileName0002.png', '')]
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO sliderPreview_valueChanged: 3
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: [('/home/ferd/.openshot_qt/blender/73885a08-c209-11e8-9996-2c27d72bd51f/TitleFileName0003.png', '')]
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO sliderPreview_valueChanged: 4
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: [('/home/ferd/.openshot_qt/blender/73885a08-c209-11e8-9996-2c27d72bd51f/TitleFileName0004.png', '')]
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO sliderPreview_valueChanged: 5
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: [('/home/ferd/.openshot_qt/blender/73885a08-c209-11e8-9996-2c27d72bd51f/TitleFileName0005.png', '')]
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []
blender_listview:INFO Image detected from blender regex: []

@ferdnyc
Common log format for param changes
a81486d 
* No bare value logging (always labeled)
* No redundant parameter logging
* Same log format in all _changed() slots
@ferdnyc
Label logged values with context
d58fbf1
@ferdnyc
Log arg to onBlenderVersionError
0d6c060
@ferdnyc
Only log if image is detected
7d610bb 
Instead of logging on _every_ pass through the blender-output scan, only 
log if an output frame is actually detected. Cuts per-frame output spam 
by ~ 95%
@ferdnyc
Copy link
Contributor Author

ferdnyc commented Sep 30, 2018

Note to self: If you get a chance before this is merged, push in another commit to rename onRenableInterface (now that you've finally figured out it's supposed to say onReenableInterface).

@DylanC
Copy link
Collaborator

DylanC commented Sep 30, 2018

@ferdnyc - Only spotted this now. I will need some time to review properly. I won't have time tonight. (Hope you don't mind)

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Oct 1, 2018

@DylanC : No rush at all, it only affects the log output and is a purely cosmetic change. (Though I do think the more structured format and higher signal:noise ratio will help when tracking down any future reported issues with the blender integration / animated titles functionality.)

@DylanC
Copy link
Collaborator

DylanC commented Oct 2, 2018

@ferdnyc - Much cleaner and easier to understand. LGTM! 👍

@DylanC DylanC merged commit 3c51e7c into OpenShot:develop Oct 2, 2018
@ferdnyc ferdnyc deleted the blender-logs branch October 2, 2018 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferdnyc @DylanC