Update craco peer deps to craco 7 alpha #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It will be really helpful if you can use the current branch and release a new alpha version. |
|
@tux-tn Can you please a have a look and release a alpha version for now? |
|
I am up for pushing this to an alpha branch and releasing against that. |
|
Thank you @kamronbatman I have rebased the branch with master |
|
Can someone please merge this in? 🙏 |
tux-tn
approved these changes
Apr 23, 2022
There was a problem hiding this comment.
sorry for taking so long guys 😓 !
LGTM ! Thank you for the great work @anuragguptanbmc . Will merge this and release an alpha version shortly
|
Thank you 🙏🙏🙏 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
craco-less needs react scripts version 5 and above but @craco/craco version 6 does not support react scripts 5.
I have created a new pre release version for craco-less (2.1.0-alpha.0) that supports craco 7.0.0-alpha releases. Once they have stable version we can update the dependency to support the latest version.
Fixed few yarn audit issues.