-
Notifications
You must be signed in to change notification settings - Fork 46
Support craco 7 #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support craco 7 #106
Conversation
Imports adjusted since craco now has a dist directory Update expected error message to match new craco repo
Is this ready to be merged, @hansjoachim ? |
Should be ready for review at least. :) I'm not that familiar with this repo, I looked into it regarding a craco7 upgrade. So after finding and testing the alpha branch, I figured that upgrading it to a stable dependency might bring it closer to release. |
project is dead? |
Any chance it will be reviewed and merged soon? |
please do something with it( |
I'll have time to test this next week and then merge. |
This getting merged soon? Upgrading to craco v7 is going to be really helpful. |
Any update? |
hi @kamronbatman , you approved this PR. What is needed now to have it merged? Can you merge it yourself? @charliemidtlyng can you merge it please ? Thanks a lot, Nicolas |
Sorry for the delay, I have been super busy. I'll try to find time this week to review it and merge. |
Hi @kamronbatman , did you get a chance to take a look at it? Thanks a lot :) |
Now that craco 7.x has a stable release, upgrade from the alpha version. This is based on the work done in #96 and should hopefully resolve #102.
For details, see the individual commit messages. I haven't tested this a lot, but the built-in test suite seems to work as expected.
When running
yarn outdated
I noticed other libraries can be upgraded as well, though I tried to keep this minimal. (And some of the libraries might be addressed by the open Dependabot PRs)Before you submit this PR, please check the following:
✔️
✔️
✔️
Some are listed, but I don't know if any new ones have been introduced.