Skip to content

Conversation

hansjoachim
Copy link

Now that craco 7.x has a stable release, upgrade from the alpha version. This is based on the work done in #96 and should hopefully resolve #102.

For details, see the individual commit messages. I haven't tested this a lot, but the built-in test suite seems to work as expected.

When running yarn outdated I noticed other libraries can be upgraded as well, though I tried to keep this minimal. (And some of the libraries might be addressed by the open Dependabot PRs)

Before you submit this PR, please check the following:

  • 100% test coverage

✔️

  • Code is formatted with Prettier

✔️

  • No ESLint warnings

✔️

  • No security vulnerabilities in any NPM packages
yarn audit

Some are listed, but I don't know if any new ones have been introduced.

@charliemidtlyng
Copy link

Is this ready to be merged, @hansjoachim ?
It would be great with an "official" version of craco-less that supports craco v7 :)

@hansjoachim
Copy link
Author

Is this ready to be merged?

Should be ready for review at least. :) I'm not that familiar with this repo, I looked into it regarding a craco7 upgrade. So after finding and testing the alpha branch, I figured that upgrading it to a stable dependency might bring it closer to release.

@perevernihata
Copy link

Getting problematic. Does anybody know if this is going to be resolved any time soon?
image

@SardukarSilver
Copy link

project is dead?

@ezze
Copy link

ezze commented Feb 2, 2023

Any chance it will be reviewed and merged soon?

@SardukarSilver
Copy link

please do something with it(

@kamronbatman
Copy link
Contributor

kamronbatman commented May 3, 2023

I'll have time to test this next week and then merge.

@yanhaijing yanhaijing mentioned this pull request May 24, 2023
@peter2gossell
Copy link

This getting merged soon? Upgrading to craco v7 is going to be really helpful.

@jvnm-dev
Copy link

Any update?

@alenden
Copy link

alenden commented Jun 29, 2023

hi @kamronbatman , you approved this PR. What is needed now to have it merged? Can you merge it yourself? @charliemidtlyng can you merge it please ? Thanks a lot, Nicolas

@kamronbatman
Copy link
Contributor

Sorry for the delay, I have been super busy. I'll try to find time this week to review it and merge.

@alenden
Copy link

alenden commented Jul 4, 2023

Sorry for the delay, I have been super busy. I'll try to find time this week to review it and merge.

Hi @kamronbatman , did you get a chance to take a look at it? Thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants