Skip to content

feat(Logger): init implementation #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2022
Merged

feat(Logger): init implementation #12

merged 1 commit into from
Feb 10, 2022

Conversation

patrykwozinski
Copy link
Contributor

@patrykwozinski patrykwozinski commented Feb 10, 2022 •
edited
Loading

That's only an implementation, without usage/replace of the current implementation from argocd.

It's a trunk-based approach.

@patrykwozinski patrykwozinski marked this pull request as ready for review February 10, 2022 16:03
alv91
alv91 approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@alv91 alv91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@patrykwozinski patrykwozinski merged commit c964c48 into develop Feb 10, 2022
@patrykwozinski patrykwozinski deleted the logger branch February 10, 2022 16:54
@patrykwozinski patrykwozinski mentioned this pull request Feb 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alv91 alv91 alv91 approved these changes

@MatteoManzoni MatteoManzoni Awaiting requested review from MatteoManzoni

+1 more reviewer

@xoanmm xoanmm xoanmm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrykwozinski @alv91 @xoanmm