feat(Logger): use zerologger instead of ArgoCD.log #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrykwozinski
commented
Feb 10, 2022
Comment on lines
+28
to
+29
| LogStashProtocol = "log-stash-protocol" | ||
| LogStashAddr = "log-stash-addr" |
There was a problem hiding this comment.
optional, new variables
alv91
approved these changes
Feb 10, 2022
MatteoManzoni
approved these changes
Feb 10, 2022
|
Closed because finally we did the implementation with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of: #12
This one pr is related to using the new logging mechanism. Also, I think it would be quite useful to introduce a dependency container to keep there all dependencies instead of passing them via configuration struct. But that's something for the future I guess.