Adding USB Support for dive computers#2
Conversation
Sese-Schneider
force-pushed
the
develop
branch
from
e284550 to
385bd8d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
…into usb-support
Sese-Schneider
left a comment
Sese-Schneider
left a comment
There was a problem hiding this comment.
Had to leave for work, here's my finalized review
| set_target_properties(libdivecomputer PROPERTIES | ||
| PUBLIC_HEADER dive_computer.h | ||
| OUTPUT_NAME "dive_computer" | ||
| OUTPUT_NAME "libdivecomputer" |
There was a problem hiding this comment.
Why does the output name need to be libdivecomputer?
| # add_compile_definitions(__APPLE__=1) | ||
| # add_compile_definitions(HAVE_HIDAPI=1) | ||
| # add_compile_definitions(HAVE_PTHREAD_H=1) |
|
@Sese-Schneider I think we should discuss if this PR can be merged or how changes should look like. Shall we have a call? |
|
@Ben1980 PR looks very good so far - I want to test it myself after the weekend and merge it ASAP. |
|
merging to develop - windows is still not working so this would be my next step to get it to main. |
2 participants
Provides USB and USB HID support for macOS.
All dependencies come via git submodules and are built during example compilation time.
Logging is also now working but needs a review.
I was only able to confirm USB HID working with Suunto EON Core, can't say if USB is working but I guess it is.