Skip to content

Comments

Build from source#1

Merged
Sese-Schneider merged 11 commits intoDiveNote:developfrom
Ben1980:build_from_source
Jan 29, 2024
Merged

Build from source#1
Sese-Schneider merged 11 commits intoDiveNote:developfrom
Ben1980:build_from_source

Conversation

@Ben1980
Copy link

@Ben1980 Ben1980 commented Jan 24, 2024

  1. libdivecomputer subrepository added
  2. CMakeLists.txt configured to build the lib
  3. Android, ios, and macos configured to build with libdivecomputer
  4. ffigen and paths slightly reconfigured so the project setup is fitting flutters ffigen template

Current Problem: The application is running and listing the different possible devices but as soon as one gets selected a Failed to lookup symbold exception has been thrown.
Bildschirmfoto 2024-01-24 um 19 31 53

@Ben1980
Copy link
Author

Ben1980 commented Jan 29, 2024

This commit is resolving the missing symbol for serial on macos, ios and android

@Sese-Schneider
Copy link
Member

Awesome, thanks @Ben1980! PR is ready, isn't it?

I'll test it out soon, and I think merge to a develop branch after to also integrate windows before merging to main

@Ben1980
Copy link
Author

Ben1980 commented Jan 29, 2024

Yes, you definitely need to look for windows. I only added serial_posix.c for android, macOS, and iOS but you will need to add serial_win32.c for Windows. From my perspective, the PR is ready for merging but the lib is far from working on my side. For example, my next work will be the unimplemented USB and BLE support. currently only serial is supported:

switch (transport) {
      case ComputerTransport.serial:
        iostream = _connectSerial(computerDescriptor);
        break;
      default:
        throw UnimplementedError();
    }

@Sese-Schneider
Copy link
Member

@Ben1980 yes, the iostream for the other transports still needs to be implemented, sorry about that.
I do think this should be a new PR though. Let's get this merged, thank you 🚀

@Sese-Schneider Sese-Schneider changed the base branch from main to develop January 29, 2024 14:14
@Sese-Schneider Sese-Schneider merged commit e284550 into DiveNote:develop Jan 29, 2024
@Ben1980 Ben1980 deleted the build_from_source branch January 29, 2024 14:21
Sese-Schneider pushed a commit that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants