Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disjoing components #73

Merged
merged 3 commits into from
Aug 2, 2022
Merged

Allow disjoing components #73

merged 3 commits into from
Aug 2, 2022

Conversation

abbiemery
Copy link
Collaborator

fixes #72

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #73 (dc84519) into master (e2e6c8f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   98.55%   98.56%           
=======================================
  Files          65       65           
  Lines        2082     2084    +2     
=======================================
+ Hits         2052     2054    +2     
  Misses         30       30           
Impacted Files Coverage Δ
tickit/core/management/event_router.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it might be an idea to add a yaml file to examples with a few disjointed components.

@callumforrester
Copy link
Contributor

Should wait until #71 is reviewed and merged so we can see the CI passing

abbiemery and others added 3 commits August 2, 2022 10:07
Co-authored-by: Garry O'Donnell <garry.o'donnell@diamond.ac.uk>
Co-authored-by: Garry O'Donnell <garry.o'donnell@diamond.ac.uk>
@abbiemery
Copy link
Collaborator Author

Looks good, it might be an idea to add a yaml file to examples with a few disjointed components.

Done with the latest commit.

@abbiemery abbiemery merged commit db5cde0 into master Aug 2, 2022
@abbiemery abbiemery deleted the fix-72 branch February 28, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disjoing components not updated
2 participants