Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies and fix test issues #71

Merged
merged 4 commits into from
Aug 2, 2022
Merged

Update dependencies and fix test issues #71

merged 4 commits into from
Aug 2, 2022

Conversation

callumforrester
Copy link
Contributor

  • Relock dependencies
  • Fix compatibility issues with pytest-asyncio 0.19.0

@callumforrester
Copy link
Contributor Author

There are also issues with the system test processes, may have to wait for @coretl to look at potential Python IOC issues

@codecov
Copy link

codecov bot commented Aug 2, 2022 •
edited
Loading

Codecov Report

Merging #71 (56dcd2b) into master (215582f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #71   +/-   ##
=======================================
  Coverage   98.55%   98.55%           
=======================================
  Files          65       65           
  Lines        2082     2082           
=======================================
  Hits         2052     2052           
  Misses         30       30

Help us with your feedback. Take ten seconds to tell us how you rate us.

@callumforrester callumforrester marked this pull request as ready for review August 2, 2022 07:56
@callumforrester callumforrester mentioned this pull request Aug 2, 2022
Merged
garryod
garryod previously approved these changes Aug 2, 2022
View reviewed changes
garryod
garryod reviewed Aug 2, 2022
View reviewed changes
Copy link
Member

@garryod garryod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would a potential alternative solution be to make these fixtures sync? Or is that not possible for some reason?

@garryod garryod dismissed their stale review August 2, 2022 08:11

Sync fixtures

@callumforrester
Copy link
Contributor Author

@garryod only in a couple of cases, have updated

@callumforrester callumforrester merged commit e2e6c8f into master Aug 2, 2022
@callumforrester callumforrester deleted the update-dependencies-and-fix-issues branch August 2, 2022 09:54
@abbiemery abbiemery mentioned this pull request Aug 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbiemery abbiemery abbiemery approved these changes

@garryod garryod garryod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@callumforrester @garryod @abbiemery