Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed method call not considering callee optional #2985

Merged
merged 10 commits into from
Dec 18, 2023
Merged

Fixed method call not considering callee optional #2985

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f42b326
fix: optional method call fixed
Bayheck Dec 12, 2023
40697c9
Merge branch 'master' of https://github.com/DevExpress/testcafe-hamme…
Bayheck Dec 12, 2023
8ebe358
fix: method call with optional owner
Bayheck Dec 14, 2023
305d573
refactor: code refactored
Bayheck Dec 14, 2023
15defe1
add: new test cases added
Bayheck Dec 14, 2023
9708e31
refactor: changed the name of the call method
Bayheck Dec 14, 2023
f4065e3
fix: tests updated
Bayheck Dec 14, 2023
72f112c
fix: method call and tests refactored
Bayheck Dec 14, 2023
6e154d0
fix: test fixed
Bayheck Dec 15, 2023
9262f9e
add: new testcase added
Bayheck Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: code refactored
  • Loading branch information
@Bayheck
Bayheck committed Dec 14, 2023
commit 305d573edfb9e06ca540b2e5e4bea44abcb02bce
6 changes: 3 additions & 3 deletions src/processing/script/transformers/method-call.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@ const transformer: Transformer<CallExpression> = {
},

run: node => {
const callee = node.callee as MemberExpression;
const method = callee.computed
const callee = node.callee as MemberExpression;
const method = callee.computed
? callee.property as Literal
: createSimpleLiteral((callee.property as Identifier).name); // eslint-disable-line no-extra-parens
const optional = (node as SimpleCallExpression).optional;
const optional = (node as SimpleCallExpression).optional;
const ownerOptional = callee.optional;

return createMethodCallWrapper(callee.object as Expression, method, node.arguments, optional, ownerOptional);
Expand Down