Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed method call not considering callee optional #2985

Merged
merged 10 commits into from
Dec 18, 2023
Merged

Fixed method call not considering callee optional #2985

merged 10 commits into from
Dec 18, 2023

Conversation

Bayheck
Copy link
Contributor

@Bayheck Bayheck commented Dec 12, 2023 •
edited
Loading

Purpose

Fixed the case for method call not considering the callee optional value.

Approach

Additional check if callee has optional in method-call

References

closes DevExpress/testcafe#7713

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@Bayheck Bayheck marked this pull request as ready for review December 13, 2023 04:37
@Bayheck Bayheck marked this pull request as draft December 13, 2023 04:57
@Bayheck Bayheck marked this pull request as ready for review December 13, 2023 08:32
@Bayheck Bayheck marked this pull request as draft December 13, 2023 08:36
@Bayheck Bayheck marked this pull request as ready for review December 13, 2023 08:42
@Aleksey28 Aleksey28 closed this Dec 13, 2023
@Aleksey28 Aleksey28 reopened this Dec 13, 2023
@AlexKamaev AlexKamaev self-requested a review December 14, 2023 06:13
@Bayheck Bayheck changed the title Gh 7713 Fixed method call not considering callee optional Dec 15, 2023
@Bayheck Bayheck deployed to authentication December 15, 2023 10:20 — with GitHub Actions Active
@AlexKamaev AlexKamaev merged commit ce25a67 into DevExpress:master Dec 18, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksey28 Aleksey28 Aleksey28 approved these changes

@AlexKamaev AlexKamaev Awaiting requested review from AlexKamaev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testcafe does not open primeng dropdown
4 participants
@Bayheck @AlexKamaev @Aleksey28 @PavelMor25