Skip to content

use cases: broke down into separate files and fixed some headers that… - #63

Merged
wesleyboar merged 5 commits into
mainfrom
silvia/separate-use-cases
Aug 12, 2024
Merged

use cases: broke down into separate files and fixed some headers that…#63
wesleyboar merged 5 commits into
mainfrom
silvia/separate-use-cases

Conversation

@silviamazzoni

@silviamazzoni silviamazzoni commented Jul 20, 2024

Copy link
Copy Markdown
Contributor

Overview

Broke down Use Cases into separate files and fixed some headers that had not been updated.

Testing

We do need to check the links from the nav because they want to connect to an anchor, not a file, which is how they are set up now.

UI

since TACC-Docs v0.10
since.tacc-docs.v0100.-.click.triangle.mov
since.tacc-docs.v0100.-.click.text.mov
using TACC-Docs v0.8 sample document header
sample.document.navbar.mov
detailed nav is automatically open
detailed.nav.is.automatically.open.mov

edited by @wesleyboar (organized and added visuals)

… had not been updated.

We do need to check the links from the nav because they want to connect to an anchor, not  a file, which is how they are set up now.
@netlify

netlify Bot commented Jul 20, 2024

Copy link
Copy Markdown

Deploy Preview for ds-user-guide failed. Why did it fail? →

Name Link
🔨 Latest commit ce7eec5
🔍 Latest deploy log https://app.netlify.com/sites/ds-user-guide/deploys/669b057cf3b5d800082b8341

@wesleyboar
wesleyboar removed the request for review from susanunit July 25, 2024 15:36
wesleyboar added a commit that referenced this pull request Jul 26, 2024
wesleyboar added a commit that referenced this pull request Jul 26, 2024
wesleyboar added a commit that referenced this pull request Jul 26, 2024
* feat: DES-3045 allow non-flat nav (TACC-Docs 0.10)

* test: DES-3045 use non-flat nav from #63

* Revert "test: DES-3045 use non-flat nav from #63"

This reverts commit 02d8621.

---------

Co-authored-by: Silvia Mazzoni <silviamazzoni@yahoo.com>
@wesleyboar

wesleyboar commented Jul 26, 2024

Copy link
Copy Markdown
Collaborator

There are navigation bugs when using flat navigation. Reported in DES-3045. Expect solution via TACC-Docs update.

@wesleyboar

wesleyboar commented Jul 26, 2024

Copy link
Copy Markdown
Collaborator

Tip

If testing via Docker, there are no navigation bugs introduced by this change.

Caution

If testing via Python, several navigation bugs are introduced by this change.

@wesleyboar wesleyboar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort of blocked by #66 because most contributors will not test via Docker.

If you are okay with the nav bugs for Python-based testing, then I'll merge this.

Otherwise, please wait until I have time to solve #66.

@silviamazzoni

Copy link
Copy Markdown
Contributor Author

Wes, do you have an update on this?

@wesleyboar

Copy link
Copy Markdown
Collaborator

No update. Same status as it was in #63 (review). I've been taken by DesignSafe website work and another project. Still an excellent PR. I don't mind it staying open, let's me know what is still waiting on me.

If you are okay with the nav bugs for Python-based testing, please tell and reopen so I can merge. Otherwise, this would wait until have time to solve #66.

@silviamazzoni

Copy link
Copy Markdown
Contributor Author

The nav bugs are are only on my testing end, correct?
And they are just style bugs?
The public version of the docs would be perfect and have the separated docs, correct?
If I want to replicate the site locally exactly, I'd have to use the docker, correct?
If so, yes, please accept this PR.

@silviamazzoni silviamazzoni reopened this Aug 12, 2024
@wesleyboar
wesleyboar merged commit 7529183 into main Aug 12, 2024
@wesleyboar
wesleyboar deleted the silvia/separate-use-cases branch August 12, 2024 17:42
@wesleyboar

Copy link
Copy Markdown
Collaborator

Yes x4. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants