-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix: update revenue calculation for opinion #4674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hottomato-c
wants to merge
1
commit into
DefiLlama:master
Choose a base branch
from
OpinionLabs:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+49
−29
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,45 +2,65 @@ import { FetchOptions, FetchResult, SimpleAdapter } from "../../adapters/types"; | |
| import { CHAIN } from "../../helpers/chains"; | ||
|
|
||
| const OPINION_CONTRACT = "0x5F45344126D6488025B0b84A3A8189F2487a7246"; | ||
| const ORDER_FILLED_EVENT = "event OrderFilled (bytes32 indexed orderHash, address indexed maker,address indexed taker, uint256 makerAssetId, uint256 takerAssetId, uint256 makerAmountFilled, uint256 takerAmountFilled, uint256 fee)"; | ||
| const OPINION_TREASURY_SAFE = "0xe76e763c5e57823ee5c7ed8e8d86d4e4938cbb4b"; | ||
| const USDT_ON_BNB_CHAIN = "0x55d398326f99059fF775485246999027B3197955"; | ||
| const ORDER_FILLED_EVENT = | ||
| "event OrderFilled (bytes32 indexed orderHash, address indexed maker,address indexed taker, uint256 makerAssetId, uint256 takerAssetId, uint256 makerAmountFilled, uint256 takerAmountFilled, uint256 fee)"; | ||
|
|
||
| async function fetch(options: FetchOptions): Promise<FetchResult> { | ||
| const dailyVolume = options.createBalances(); | ||
| const dailyFees = options.createBalances(); | ||
| const dailyVolume = options.createBalances(); | ||
| const dailyFees = options.createBalances(); | ||
| const dailyRevenue = options.createBalances(); | ||
|
|
||
| const orderFilledLogs = await options.getLogs({ | ||
| eventAbi: ORDER_FILLED_EVENT, | ||
| target: OPINION_CONTRACT | ||
| }); | ||
| const orderFilledLogs = await options.getLogs({ | ||
| eventAbi: ORDER_FILLED_EVENT, | ||
| target: OPINION_CONTRACT, | ||
| }); | ||
|
|
||
| orderFilledLogs.forEach((order: any) => { | ||
| const tradeVolume = Number(order.makerAssetId == 0 ? order.makerAmountFilled : order.takerAmountFilled) / 1e18; | ||
| dailyVolume.addUSDValue(tradeVolume); | ||
| dailyFees.addUSDValue(Number(order.fee) / 1e18); | ||
| }); | ||
| const usdtTransferLogs = await options.getLogs({ | ||
| eventAbi: | ||
| "event Transfer(address indexed from, address indexed to, uint256 value)", | ||
| target: USDT_ON_BNB_CHAIN, | ||
| }); | ||
|
|
||
| orderFilledLogs.forEach((order: any) => { | ||
| const tradeVolume = | ||
| Number( | ||
| order.makerAssetId == 0 | ||
| ? order.makerAmountFilled | ||
| : order.takerAmountFilled | ||
| ) / 1e18; | ||
| dailyVolume.addUSDValue(tradeVolume); | ||
| dailyFees.addUSDValue(Number(order.fee) / 1e18); | ||
| }); | ||
|
|
||
| return { | ||
| dailyVolume, | ||
| dailyFees, | ||
| dailyRevenue: dailyFees, | ||
| dailyProtocolRevenue: dailyFees, | ||
| } | ||
| usdtTransferLogs | ||
| .filter((transfer: any) => transfer.to === OPINION_TREASURY_SAFE) | ||
| .forEach((transfer: any) => { | ||
| dailyRevenue.add(USDT_ON_BNB_CHAIN, Number(transfer.value) / 1e18); | ||
| }); | ||
|
|
||
| return { | ||
| dailyVolume, | ||
| dailyFees, | ||
| dailyRevenue: dailyRevenue, | ||
| dailyProtocolRevenue: dailyRevenue, | ||
| }; | ||
| } | ||
|
|
||
| const methodology = { | ||
| Volume: "Opinion prediction market trading volume", | ||
| Fees: "Taker fees collected by opinion", | ||
| Revenue: "All the fees are revenue", | ||
| ProtocolRevenue: "All the revenue goes to protocol", | ||
| Volume: "Opinion prediction market trading volume", | ||
| Fees: "Taker fees collected by opinion", | ||
| Revenue: "All the fees are revenue", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If all fees are revenue,why did you need to count USDT transfer to Safe Wallet? |
||
| ProtocolRevenue: "All the revenue goes to protocol", | ||
| }; | ||
|
|
||
| const adapter: SimpleAdapter = { | ||
| version: 2, | ||
| fetch, | ||
| methodology, | ||
| chains: [CHAIN.BSC], | ||
| start: '2025-10-22', | ||
| } | ||
| version: 2, | ||
| fetch, | ||
| methodology, | ||
| chains: [CHAIN.BSC], | ||
| start: "2025-10-22", | ||
| }; | ||
|
|
||
| export default adapter; | ||
| export default adapter; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revenue should be equal to fees, so we don't need to pull USDT transfer log?