-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix: update revenue calculation for opinion #4674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The opinion adapter exports: |
| ProtocolRevenue: "All the revenue goes to protocol", | ||
| Volume: "Opinion prediction market trading volume", | ||
| Fees: "Taker fees collected by opinion", | ||
| Revenue: "All the fees are revenue", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If all fees are revenue,why did you need to count USDT transfer to Safe Wallet?
| dailyVolume.addUSDValue(tradeVolume); | ||
| dailyFees.addUSDValue(Number(order.fee) / 1e18); | ||
| }); | ||
| const usdtTransferLogs = await options.getLogs({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revenue should be equal to fees, so we don't need to pull USDT transfer log?
noateden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
NOTE
Please enable "Allow edits by maintainers" while putting up the PR.
poackage.json/package-lock.jsonfile as part of your changesUpdate revenue tracking for Opinion... Revenue = Income of our treasury on BNB Chain