Incorporate Ludusavi manifest #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidDeSimone
commented
Apr 17, 2023
core/game_record_manager.go
Outdated
Comment on lines
255
to
270
| func (grm *GameRecordManagerImpl) CommitCustomGameRecords() error { | ||
| grm.mu.Lock() | ||
| defer grm.mu.Unlock() | ||
|
|
||
| data, err := yaml.Marshal(grm.gameRecords) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| err = os.WriteFile(grm.manifestLocation, data, os.ModePerm) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return nil | ||
| } |
There was a problem hiding this comment.
Needs to store this as binary, not yaml
DavidDeSimone
commented
Apr 17, 2023
core/game_record_manager.go
Outdated
Comment on lines
238
to
253
| func (grm *GameRecordManagerImpl) RefreshManifestFromDisk() error { | ||
| grm.mu.Lock() | ||
| defer grm.mu.Unlock() | ||
|
|
||
| data, err := os.ReadFile(grm.manifestLocation) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| err = yaml.Unmarshal(data, &grm.gameRecords) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return nil | ||
| } |
There was a problem hiding this comment.
Needs to read binary, not yml
DavidDeSimone
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR for adding support for the Ludusavi manifest. This will add over 46,000 (!!!) game definitions available on the app. This will have the ability to update in real time as the manifest updates.