feat(plugins/loadingIndicator): migrate plugin#363
Merged
Conversation
dopenguin
added
enhancement
dopenguin
changed the title
…ate loading styles to vue@3
…ling to fit design
…ponent if it is not the default
…-loading-indicator # Conflicts: # examples/snowbox/index.js
…-loading-indicator
…-loading-indicator # Conflicts: # examples/snowbox/index.js # src/core/types/plugin.ts
…-loading-indicator
…-loading-indicator
Member
Author
|
@oeninghe-dataport I've set the base branch to |
…-loading-indicator
oeninghe-dataport
requested changes
Nov 18, 2025
src/plugins/loadingIndicator/components/loaderStyles/BasicLoader.ce.vue
Outdated
Show resolved
Hide resolved
src/plugins/loadingIndicator/components/loaderStyles/RingLoader.ce.vue
Outdated
Show resolved
Hide resolved
src/plugins/loadingIndicator/components/loaderStyles/RollerLoader.ce.vue
Outdated
Show resolved
Hide resolved
src/plugins/loadingIndicator/components/loaderStyles/SpinnerLoader.ce.vue
Outdated
Show resolved
Hide resolved
refactor(loadingIndicator): shorten template of loaders Co-authored-by: Hendrik Oenings <142312676+oeninghe-dataport@users.noreply.github.com>
Member
Author
Collaborator
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate LoadingIndicator plugin to
@polar/polar.Instructions for local reproduction and review
Open the snowbox. A loading indicator should be shown on start which dissapears after 2 seconds
Relevant tickets, issues, et cetera
Closes #349, Blocked by #357, #358 & #360