feat(plugins/iconMenu): migrate plugin#357
Merged
Conversation
Using the component adds the possibility of adding a tooltip for the button placed depending on the given tooltipPosition. If the prop is not given, no tooltip is shown.
…if it is supposed to be active
Update PolarIconButton as well to accommodate for additionally needed parameters for the t-function.
… is shown over other content
…ement in PolarIconButton
… it correctly in standard
# Conflicts: # src/plugins/iconMenu/components/NineRegionsButton.ce.vue # src/plugins/iconMenu/components/NineRegionsMenu.ce.vue # src/plugins/iconMenu/components/TopRightMenu.ce.vue
Added todo, as this seemingly doesn't work with deep.
Order is relevant regarding tab order.
dopenguin
requested review from
oeninghe-dataport and
warm-coolguy
as code owners
dopenguin
added
enhancement
…placed in the top right corner
…nu grouping for standard layout
…on for labeled menu addition
Member
Author
|
@oeninghe-dataport The plugin has been updated to include two menu types ( The only thing missing now is the way we are going to be handling the position of the content of the |
Member
Author
|
Only #357 (comment) seems to be left, which is blocked by #356. Do you see any additional need for changes on this PR? |
# Conflicts: # examples/snowbox/index.js # src/plugins/fullscreen/components/FullscreenUI.ce.vue # src/plugins/fullscreen/components/FullscreenUI.spec.ts # src/plugins/iconMenu/components/NineRegionsButton.ce.vue # src/plugins/iconMenu/store.ts # src/plugins/iconMenu/types.ts
# Conflicts: # package-lock.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate IconMenu plugin to
@polar/polar.Instructions for local reproduction and review
Snowbox provides an iconMenu for layout
ninenRegionsandstandard.Relevant tickets, issues, et cetera
Closes #345