Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimization-2655][core] Optimize data preview in data studio #2656

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

aiwenmo
Copy link
Contributor

@aiwenmo aiwenmo commented Dec 15, 2023

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@aiwenmo aiwenmo self-assigned this Dec 15, 2023
@aiwenmo aiwenmo added the Optimization Optimization function label Dec 15, 2023
@aiwenmo aiwenmo added this to the 1.0.0 milestone Dec 15, 2023
Copy link
Contributor

@gaoyan1998 gaoyan1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaoyan1998 gaoyan1998 merged commit 4a932b7 into DataLinkDC:dev Dec 15, 2023
leechor pushed a commit to leechor/dinky that referenced this pull request Dec 16, 2023
…inkDC#2656)

* [Optimization-2655][core] Optimize data preview in data studio

* optimize code

---------

Co-authored-by: wenmo <32723967+wenmo@users.noreply.github.com>
Zzm0809 pushed a commit that referenced this pull request Dec 16, 2023
* feat: add edit words suggestion

Signed-off-by: licho <lecho.sun@gmail.com>

* Spotless Apply

* [Optimization-2655][core] Optimize data preview in data studio (#2656)

* [Optimization-2655][core] Optimize data preview in data studio

* optimize code

---------

Co-authored-by: wenmo <32723967+wenmo@users.noreply.github.com>

* feat: add explain error line for some (#2657)

* feat: add explain error line for some

Signed-off-by: licho <lecho.sun@gmail.com>

* Spotless Apply

---------

Signed-off-by: licho <lecho.sun@gmail.com>
Co-authored-by: leechor <leechor@users.noreply.github.com>

* feat: add lazy invoke

Signed-off-by: licho <lecho.sun@gmail.com>

---------

Signed-off-by: licho <lecho.sun@gmail.com>
Co-authored-by: leechor <leechor@users.noreply.github.com>
Co-authored-by: aiwenmo <32723967+aiwenmo@users.noreply.github.com>
Co-authored-by: wenmo <32723967+wenmo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Optimization Optimization function
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants