Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add explain error line for some #2657

Merged
merged 2 commits into from
Dec 16, 2023

Conversation

leechor
Copy link
Contributor

@leechor leechor commented Dec 16, 2023

No description provided.

Signed-off-by: licho <lecho.sun@gmail.com>
@leechor leechor requested a review from gaoyan1998 December 16, 2023 02:40
Copy link
Contributor

@Zzm0809 Zzm0809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zzm0809 Zzm0809 merged commit 9a3cb09 into DataLinkDC:dev Dec 16, 2023
12 checks passed
leechor added a commit to leechor/dinky that referenced this pull request Dec 16, 2023
* feat: add explain error line for some

Signed-off-by: licho <lecho.sun@gmail.com>

* Spotless Apply

---------

Signed-off-by: licho <lecho.sun@gmail.com>
Co-authored-by: leechor <leechor@users.noreply.github.com>
Zzm0809 pushed a commit that referenced this pull request Dec 16, 2023
* feat: add edit words suggestion

Signed-off-by: licho <lecho.sun@gmail.com>

* Spotless Apply

* [Optimization-2655][core] Optimize data preview in data studio (#2656)

* [Optimization-2655][core] Optimize data preview in data studio

* optimize code

---------

Co-authored-by: wenmo <32723967+wenmo@users.noreply.github.com>

* feat: add explain error line for some (#2657)

* feat: add explain error line for some

Signed-off-by: licho <lecho.sun@gmail.com>

* Spotless Apply

---------

Signed-off-by: licho <lecho.sun@gmail.com>
Co-authored-by: leechor <leechor@users.noreply.github.com>

* feat: add lazy invoke

Signed-off-by: licho <lecho.sun@gmail.com>

---------

Signed-off-by: licho <lecho.sun@gmail.com>
Co-authored-by: leechor <leechor@users.noreply.github.com>
Co-authored-by: aiwenmo <32723967+aiwenmo@users.noreply.github.com>
Co-authored-by: wenmo <32723967+wenmo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants