Skip to content

Conversation

@Mathew-Estafanous
Copy link
Contributor

@Mathew-Estafanous Mathew-Estafanous commented Sep 3, 2025

What does this PR do?

Motivation

A customer requested the ability to configure log router level environment variables in addition to the datadog agent. Currently, only the agent can be configured with dd_environment so this PR adds a similar option to dd_log_collection

Describe how you validated your changes

  1. Updated logging_only_test.go test to validate env vars passed to dd_log_collection.fluentbit_config.environment are passed down to the container task def.

  2. Manually QAd by provisioning an ecs fargate task with an added environment var in the dd_log_collection then confirmed the env var is found in the task def on aws console.

Manual test results

Config:
image

AWS Console
image

Additional Notes

@Mathew-Estafanous Mathew-Estafanous self-assigned this Sep 3, 2025
@Mathew-Estafanous Mathew-Estafanous requested a review from a team as a code owner September 3, 2025 20:59
Copy link
Collaborator

@gabedos gabedos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for making the task_family_name a configurable variable. You must've run into some conflicts when I also had the same resources generated in the same account.

@Mathew-Estafanous Mathew-Estafanous merged commit 1542b98 into main Sep 4, 2025
5 checks passed
@gabedos
Copy link
Collaborator

gabedos commented Sep 4, 2025

#33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants