Skip to content

[crashtracker] Enable timeout on receiver#702

Merged
danielsn merged 10 commits intomainfrom
dsn/crashtracker-receiver-timeout
Nov 6, 2024
Merged

[crashtracker] Enable timeout on receiver#702
danielsn merged 10 commits intomainfrom
dsn/crashtracker-receiver-timeout

Conversation

@danielsn
Copy link
Contributor

@danielsn danielsn commented Oct 31, 2024 •
edited
Loading

What does this PR do?

Adds a timeout to the crashtracker receiver, enabling it to post a partial crash report if the collector hangs. Previously, a collector hang could cause the receiver to also hang.

Motivation

This implements a mitigation from the RFC.

Additional Notes

There is an open question about how to configure this timeout. Currently, we're offering an environment variable. We could take the value from the config, but that is passed on the socket, so its odd for a timeout on the socket to depend on a value that came on the socket.

How to test the change?

Added two new tests.

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.60714% with 15 lines in your changes missing coverage. Please review.

Project coverage is 71.54%. Comparing base (7c08b25) to head (aca4820).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
+ Coverage   71.25%   71.54%   +0.28%     
==========================================
  Files         281      281              
  Lines       42315    42422     +107     
==========================================
+ Hits        30150    30349     +199     
+ Misses      12165    12073      -92
Components Coverage Δ
crashtracker 43.37% <86.60%> (+6.07%) ⬆️
crashtracker-ffi 9.20% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.93% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.46% <ø> (ø)
ddcommon-ffi 69.12% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 89.45% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.75% <ø> (ø)
profiling 84.30% <ø> (ø)
profiling-ffi 77.46% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 37.42% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.45% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.55% <ø> (ø)

@pr-commenter
Copy link

pr-commenter bot commented Oct 31, 2024 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2024-11-06 21:56:33

Comparing candidate commit aca4820 in PR branch dsn/crashtracker-receiver-timeout with baseline commit 7c08b25 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aca4820 1730929546 dsn/crashtracker-receiver-timeout
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 290.639ns 303.078ns ± 15.203ns 296.601ns ± 4.564ns 310.131ns 336.969ns 352.556ns 357.306ns 20.47% 1.866 3.045 5.00% 1.075ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [300.971ns; 305.185ns] or [-0.695%; +0.695%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aca4820 1730929546 dsn/crashtracker-receiver-timeout
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.136µs 1.205µs ± 0.024µs 1.212µs ± 0.010µs 1.222µs 1.227µs 1.229µs 1.229µs 1.40% -1.677 1.918 1.98% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.202µs; 1.208µs] or [-0.275%; +0.275%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aca4820 1730929546 dsn/crashtracker-receiver-timeout
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 142.687µs 143.667µs ± 0.372µs 143.645µs ± 0.181µs 143.828µs 144.157µs 144.631µs 145.797µs 1.50% 1.287 7.108 0.26% 0.026µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [143.616µs; 143.719µs] or [-0.036%; +0.036%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aca4820 1730929546 dsn/crashtracker-receiver-timeout
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.616µs 2.678µs ± 0.020µs 2.678µs ± 0.013µs 2.690µs 2.710µs 2.721µs 2.728µs 1.88% -0.430 0.752 0.76% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.675µs; 2.681µs] or [-0.105%; +0.105%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aca4820 1730929546 dsn/crashtracker-receiver-timeout
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.663µs 23.333µs ± 9.639µs 18.648µs ± 0.228µs 26.775µs 36.351µs 41.818µs 96.446µs 417.20% 3.398 18.662 41.21% 0.682µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [21.997µs; 24.669µs] or [-5.726%; +5.726%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aca4820 1730929546 dsn/crashtracker-receiver-timeout
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 73.965µs 74.349µs ± 0.177µs 74.390µs ± 0.104µs 74.456µs 74.550µs 74.599µs 75.669µs 1.72% 1.850 13.883 0.24% 0.012µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [74.325µs; 74.374µs] or [-0.033%; +0.033%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aca4820 1730929546 dsn/crashtracker-receiver-timeout
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 251.720µs 252.155µs ± 0.291µs 252.118µs ± 0.105µs 252.222µs 252.443µs 252.897µs 254.871µs 1.09% 5.547 44.671 0.12% 0.021µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3923550.504op/s 3965825.698op/s ± 4544.259op/s 3966404.046op/s ± 1651.163op/s 3968007.746op/s 3969913.765op/s 3970947.173op/s 3972662.444op/s 0.16% -5.493 44.001 0.11% 321.328op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 24.640µs 24.803µs ± 0.055µs 24.800µs ± 0.039µs 24.845µs 24.892µs 24.915µs 24.923µs 0.49% -0.094 -0.405 0.22% 0.004µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 40123744.600op/s 40317795.566op/s ± 89705.391op/s 40322264.725op/s ± 63880.450op/s 40380481.358op/s 40456545.424op/s 40496466.800op/s 40584827.362op/s 0.65% 0.104 -0.396 0.22% 6343.129op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 15.717µs 15.750µs ± 0.037µs 15.728µs ± 0.006µs 15.768µs 15.808µs 15.872µs 15.996µs 1.70% 2.730 12.701 0.23% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 62514228.499op/s 63492407.413op/s ± 147426.128op/s 63579476.863op/s ± 25999.569op/s 63595330.196op/s 63605628.144op/s 63610917.968op/s 63624193.099op/s 0.07% -2.680 12.268 0.23% 10424.601op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [252.114µs; 252.195µs] or [-0.016%; +0.016%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3965195.907op/s; 3966455.489op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [24.795µs; 24.811µs] or [-0.031%; +0.031%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [40305363.261op/s; 40330227.870op/s] or [-0.031%; +0.031%] None None None
normalization/normalize_name/normalize_name/good execution_time [15.745µs; 15.755µs] or [-0.032%; +0.032%] None None None
normalization/normalize_name/normalize_name/good throughput [63471975.570op/s; 63512839.257op/s] or [-0.032%; +0.032%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aca4820 1730929546 dsn/crashtracker-receiver-timeout
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.076ms 9.113ms ± 0.021ms 9.113ms ± 0.011ms 9.124ms 9.138ms 9.149ms 9.292ms 1.97% 3.235 26.353 0.23% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.110ms; 9.116ms] or [-0.031%; +0.031%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aca4820 1730929546 dsn/crashtracker-receiver-timeout
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.370µs 3.290µs ± 1.426µs 3.110µs ± 0.026µs 3.134µs 3.552µs 14.049µs 15.099µs 385.45% 7.497 56.789 43.23% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.093µs; 3.488µs] or [-6.006%; +6.006%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aca4820 1730929546 dsn/crashtracker-receiver-timeout
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.606µs 4.618µs ± 0.003µs 4.618µs ± 0.002µs 4.620µs 4.623µs 4.626µs 4.627µs 0.19% 0.017 1.373 0.06% 0.000µs 1 200
credit_card/is_card_number/ throughput 216120299.383op/s 216531637.829op/s ± 133973.374op/s 216526889.696op/s ± 88150.809op/s 216622539.576op/s 216734401.338op/s 216754264.011op/s 217114474.459op/s 0.27% -0.011 1.383 0.06% 9473.348op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 89.909µs 91.291µs ± 0.723µs 91.146µs ± 0.374µs 91.650µs 92.421µs 93.520µs 96.131µs 5.47% 1.982 9.443 0.79% 0.051µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10402502.123op/s 10954663.945op/s ± 85495.065op/s 10971426.044op/s ± 45153.358op/s 10999908.155op/s 11058079.134op/s 11106309.304op/s 11122355.925op/s 1.38% -1.814 8.127 0.78% 6045.414op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 85.151µs 86.212µs ± 0.454µs 86.210µs ± 0.120µs 86.355µs 86.697µs 86.988µs 90.433µs 4.90% 3.736 36.027 0.53% 0.032µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 11057855.462op/s 11599623.904op/s ± 60017.197op/s 11599605.613op/s ± 16165.700op/s 11613839.946op/s 11686413.903op/s 11741042.157op/s 11743875.392op/s 1.24% -3.370 32.077 0.52% 4243.857op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.603µs 4.618µs ± 0.003µs 4.618µs ± 0.002µs 4.620µs 4.622µs 4.624µs 4.625µs 0.15% -0.760 4.117 0.06% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 216193081.382op/s 216534435.337op/s ± 128630.858op/s 216527885.389op/s ± 83118.780op/s 216623877.367op/s 216728499.414op/s 216770596.309op/s 217269189.102op/s 0.34% 0.770 4.172 0.06% 9095.575op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 81.806µs 83.373µs ± 0.427µs 83.442µs ± 0.273µs 83.693µs 83.955µs 84.236µs 84.310µs 1.04% -0.630 0.469 0.51% 0.030µs 1 200
credit_card/is_card_number/378282246310005 throughput 11861020.599op/s 11994537.909op/s ± 61588.545op/s 11984351.621op/s ± 39280.109op/s 12036526.043op/s 12108674.535op/s 12167181.515op/s 12223994.084op/s 2.00% 0.662 0.540 0.51% 4354.968op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 58.055µs 58.526µs ± 0.347µs 58.565µs ± 0.320µs 58.872µs 58.943µs 59.074µs 59.121µs 0.95% -0.093 -1.577 0.59% 0.025µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16914378.230op/s 17087087.602op/s ± 101273.277op/s 17074947.637op/s ± 92887.194op/s 17204263.865op/s 17221661.914op/s 17224540.507op/s 17225152.793op/s 0.88% 0.100 -1.578 0.59% 7161.102op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.539µs 6.545µs ± 0.005µs 6.545µs ± 0.001µs 6.546µs 6.548µs 6.550µs 6.609µs 0.98% 11.070 141.736 0.08% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 151298004.193op/s 152786620.229op/s ± 114588.466op/s 152784721.532op/s ± 34900.178op/s 152833929.134op/s 152856060.725op/s 152868264.706op/s 152927709.931op/s 0.09% -11.022 140.910 0.07% 8102.628op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.606µs 4.619µs ± 0.003µs 4.619µs ± 0.002µs 4.620µs 4.623µs 4.625µs 4.626µs 0.15% -0.188 0.996 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 216182098.386op/s 216516350.388op/s ± 130278.721op/s 216516770.953op/s ± 96258.745op/s 216617242.733op/s 216723526.992op/s 216773052.543op/s 217091712.729op/s 0.27% 0.193 1.011 0.06% 9212.097op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 67.289µs 68.474µs ± 0.627µs 68.447µs ± 0.493µs 68.935µs 69.539µs 69.888µs 70.248µs 2.63% 0.205 -0.494 0.91% 0.044µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14235362.610op/s 14605229.381op/s ± 133532.200op/s 14609845.581op/s ± 105229.876op/s 14714516.768op/s 14814587.979op/s 14860625.819op/s 14861348.706op/s 1.72% -0.165 -0.527 0.91% 9442.152op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 62.727µs 63.469µs ± 0.466µs 63.369µs ± 0.295µs 63.732µs 64.373µs 64.489µs 64.604µs 1.95% 0.589 -0.478 0.73% 0.033µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 15478867.672op/s 15756517.221op/s ± 115206.192op/s 15780552.069op/s ± 73446.515op/s 15837095.763op/s 15908698.305op/s 15936270.459op/s 15942177.118op/s 1.02% -0.563 -0.509 0.73% 8146.308op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.605µs 4.619µs ± 0.003µs 4.618µs ± 0.002µs 4.621µs 4.623µs 4.625µs 4.626µs 0.16% -0.236 2.440 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 216181796.315op/s 216514194.442op/s ± 128572.620op/s 216525190.548op/s ± 91142.324op/s 216613283.810op/s 216680817.615op/s 216742882.544op/s 217167023.097op/s 0.30% 0.243 2.471 0.06% 9091.457op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 60.156µs 60.393µs ± 0.208µs 60.372µs ± 0.179µs 60.538µs 60.767µs 60.876µs 60.900µs 0.88% 0.580 -0.726 0.34% 0.015µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 16420354.751op/s 16558415.817op/s ± 56952.956op/s 16564042.835op/s ± 49205.401op/s 16613383.742op/s 16621928.729op/s 16623190.032op/s 16623555.578op/s 0.36% -0.571 -0.745 0.34% 4027.182op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 58.056µs 58.633µs ± 0.325µs 58.859µs ± 0.110µs 58.894µs 58.939µs 59.056µs 59.078µs 0.37% -0.663 -1.144 0.55% 0.023µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16926637.380op/s 17055624.790op/s ± 94868.696op/s 16989832.832op/s ± 31675.375op/s 17147058.987op/s 17220503.400op/s 17223812.290op/s 17224883.853op/s 1.38% 0.670 -1.135 0.55% 6708.230op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.539µs 6.545µs ± 0.002µs 6.545µs ± 0.002µs 6.546µs 6.550µs 6.551µs 6.554µs 0.13% 0.650 0.030 0.04% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 152586485.731op/s 152790403.902op/s ± 57887.816op/s 152788586.699op/s ± 46909.345op/s 152839577.809op/s 152858729.088op/s 152869640.529op/s 152933465.035op/s 0.09% -0.648 0.026 0.04% 4093.287op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.618µs; 4.619µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ throughput [216513070.407op/s; 216550205.250op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [91.191µs; 91.391µs] or [-0.110%; +0.110%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10942815.151op/s; 10966512.739op/s] or [-0.108%; +0.108%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [86.149µs; 86.275µs] or [-0.073%; +0.073%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11591306.097op/s; 11607941.710op/s] or [-0.072%; +0.072%] None None None
credit_card/is_card_number/37828224631 execution_time [4.618µs; 4.619µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/37828224631 throughput [216516608.337op/s; 216552262.337op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/378282246310005 execution_time [83.314µs; 83.433µs] or [-0.071%; +0.071%] None None None
credit_card/is_card_number/378282246310005 throughput [11986002.329op/s; 12003073.489op/s] or [-0.071%; +0.071%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [58.478µs; 58.574µs] or [-0.082%; +0.082%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [17073052.099op/s; 17101123.104op/s] or [-0.082%; +0.082%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.544µs; 6.546µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/x371413321323331 throughput [152770739.369op/s; 152802501.088op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.618µs; 4.619µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ throughput [216498295.010op/s; 216534405.766op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [68.387µs; 68.561µs] or [-0.127%; +0.127%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [14586723.103op/s; 14623735.660op/s] or [-0.127%; +0.127%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [63.405µs; 63.534µs] or [-0.102%; +0.102%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15740550.751op/s; 15772483.691op/s] or [-0.101%; +0.101%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.618µs; 4.619µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [216496375.513op/s; 216532013.370op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [60.364µs; 60.422µs] or [-0.048%; +0.048%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [16550522.685op/s; 16566308.949op/s] or [-0.048%; +0.048%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [58.588µs; 58.679µs] or [-0.077%; +0.077%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [17042476.901op/s; 17068772.679op/s] or [-0.077%; +0.077%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.545µs; 6.545µs] or [-0.005%; +0.005%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [152782381.208op/s; 152798426.597op/s] or [-0.005%; +0.005%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aca4820 1730929546 dsn/crashtracker-receiver-timeout
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 37.058µs 37.516µs ± 0.816µs 37.168µs ± 0.082µs 37.231µs 39.232µs 39.326µs 40.349µs 8.56% 1.729 1.180 2.17% 0.058µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [37.403µs; 37.629µs] or [-0.301%; +0.301%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aca4820 1730929546 dsn/crashtracker-receiver-timeout
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 507.200µs 507.856µs ± 0.281µs 507.820µs ± 0.183µs 508.042µs 508.362µs 508.589µs 508.693µs 0.17% 0.462 0.190 0.06% 0.020µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1965820.624op/s 1969062.807op/s ± 1087.549op/s 1969200.887op/s ± 710.513op/s 1969766.232op/s 1970648.980op/s 1971061.471op/s 1971607.461op/s 0.12% -0.459 0.186 0.06% 76.901op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 477.564µs 478.630µs ± 0.419µs 478.617µs ± 0.263µs 478.881µs 479.293µs 479.607µs 479.885µs 0.26% 0.005 0.215 0.09% 0.030µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2083830.985op/s 2089300.289op/s ± 1830.913op/s 2089351.444op/s ± 1149.303op/s 2090385.979op/s 2092671.801op/s 2093701.400op/s 2093958.566op/s 0.22% 0.001 0.214 0.09% 129.465op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 184.096µs 184.557µs ± 0.169µs 184.575µs ± 0.116µs 184.679µs 184.814µs 184.880µs 184.982µs 0.22% -0.324 -0.106 0.09% 0.012µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5405934.310op/s 5418390.037op/s ± 4977.549op/s 5417858.426op/s ± 3401.233op/s 5421657.374op/s 5426939.101op/s 5431299.508op/s 5431942.647op/s 0.26% 0.329 -0.102 0.09% 351.966op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 46.710µs 47.035µs ± 0.126µs 47.035µs ± 0.080µs 47.113µs 47.234µs 47.341µs 47.529µs 1.05% 0.294 0.878 0.27% 0.009µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 21039699.559op/s 21260938.726op/s ± 56917.798op/s 21260726.910op/s ± 36142.219op/s 21297450.361op/s 21351593.520op/s 21389303.853op/s 21408647.057op/s 0.70% -0.271 0.841 0.27% 4024.696op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 49.804µs 50.770µs ± 0.395µs 50.796µs ± 0.258µs 51.033µs 51.374µs 51.518µs 51.838µs 2.05% -0.197 -0.256 0.78% 0.028µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19290775.764op/s 19697689.385op/s ± 153600.986op/s 19686776.439op/s ± 100152.148op/s 19798785.022op/s 19970247.434op/s 20040551.732op/s 20078765.454op/s 1.99% 0.236 -0.254 0.78% 10861.230op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [507.817µs; 507.895µs] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1968912.083op/s; 1969213.531op/s] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [478.571µs; 478.688µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2089046.542op/s; 2089554.036op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [184.533µs; 184.580µs] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5417700.196op/s; 5419079.877op/s] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [47.017µs; 47.052µs] or [-0.037%; +0.037%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21253050.467op/s; 21268826.986op/s] or [-0.037%; +0.037%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [50.716µs; 50.825µs] or [-0.108%; +0.108%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [19676401.766op/s; 19718977.005op/s] or [-0.108%; +0.108%] None None None

Baseline

Omitted due to size.

@danielsn danielsn force-pushed the dsn/crashtracker-receiver-timeout branch from f8a5aab to 2d5d0f9 Compare November 1, 2024 19:00
@danielsn danielsn force-pushed the dsn/crashtracker-receiver-timeout branch from 2d5d0f9 to e1d9f38 Compare November 1, 2024 19:04
@danielsn danielsn marked this pull request as ready for review November 1, 2024 19:17
@danielsn danielsn requested a review from a team as a code owner November 1, 2024 19:17
sanchda
sanchda approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@sanchda sanchda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I added some comments for discussion, but none of them block this PR.

@danielsn danielsn mentioned this pull request Nov 6, 2024
Open
sanchda and others added 6 commits November 6, 2024 16:45
@sanchda @danielsn
Bump version to v14.0.0 (#708)
250151f 
Bump to v14.0.0
@taegyunkim @danielsn
chore(ci): stop using macos-12 in github actions (#710)
df286cc
@sanchda @danielsn
v14.0.0 release for Ruby (#709)
42d196f
@bwoebi @danielsn
Collect agent info from sidecar (#701)
eec4b33 
* Collect agent info from sidecar

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>

* Add comments and test for AgentInfo in sidecar

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>

---------

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@sanchda @danielsn
[crashtracking] fix SA_ONSTACK (#713)
0e0b07d 
Fixes `use_alt_stack` to actually do something and adds tests
@danielsn
PR Comments
4cb2cb3
@danielsn danielsn requested review from a team as code owners November 6, 2024 21:45
@danielsn danielsn requested a review from a team November 6, 2024 21:45
@danielsn danielsn requested a review from a team as a code owner November 6, 2024 21:45
@danielsn danielsn merged commit bc73d15 into main Nov 6, 2024
@danielsn danielsn deleted the dsn/crashtracker-receiver-timeout branch November 6, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sanchda sanchda sanchda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@danielsn @codecov-commenter @sanchda @taegyunkim @bwoebi