Conversation
bwoebi
force-pushed
the
bob/agent-info
branch
from
ef4bc6b to
8c62f6a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #701 +/- ##
==========================================
- Coverage 70.64% 70.60% -0.04%
==========================================
Files 280 281 +1
Lines 41805 41980 +175
==========================================
+ Hits 29532 29642 +110
- Misses 12273 12338 +65
|
BenchmarksComparisonBenchmark execution time: 2024-11-05 12:07:19 Comparing candidate commit da154f2 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
BaselineOmitted due to size. |
bantonsson
requested changes
Oct 31, 2024
Contributor
bantonsson
left a comment
bantonsson
left a comment
There was a problem hiding this comment.
Please add comments and tests.
| infos: Shared<ManualFuture<AgentInfoStruct>>, | ||
| } | ||
|
|
||
| impl AgentInfoFetcher { |
Contributor
There was a problem hiding this comment.
This file has no comments or tests 😞 I also find it confusing that this has the same name AgentInfoFetcher as the AgentInfoFetcher in data-pipeline. Yes, I know that there are differences, but couldn't the break check, and the processing be moved behind a trait and there only be one impl of the loop?
Contributor
Author
There was a problem hiding this comment.
I wasn't intentionally choosing the same name. Maybe I can call it AgentInfoWriter, but not sure if that helps?
You theoretically could do it, but the actual amount of shared code would be quite low & the boilerplate for the sharing of code quite large in comparison? I feel like fetch_info_with_state is the right level of abstraction for this.
I can though add at least a test for the happy path here.
Contributor
There was a problem hiding this comment.
Fine, let's not try to share more code then.
Please add a happy path test and some comments. I mean at least something like:
//! This file contains code for fetching and sharing the info from the Datadog Agent
//! ... etc
Contributor
Author
There was a problem hiding this comment.
Yes, I will do, just haven't gotten round to it yet.
bwoebi
force-pushed
the
bob/agent-info
branch
2 times, most recently
from
73e5f69 to
fe3c47e
Compare
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi
force-pushed
the
bob/agent-info
branch
from
fe3c47e to
da154f2
Compare
bantonsson
approved these changes
Nov 6, 2024
danielsn
pushed a commit
that referenced
this pull request
Nov 6, 2024
* Collect agent info from sidecar Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Add comments and test for AgentInfo in sidecar Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> --------- Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tracer needs to know about the env default (to properly apply it).
This PR provides the ability to store the agent info in shared memory (polling every 60 sec).