Repository navigation
fix(crashtracking): honor proxy environment variables - #2462
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
Conversation
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 6b3ffba | Docs | View more details | Give us feedback! |
BenchmarksComparisonBenchmark execution time: 2026-09-09 21:58:28 Comparing candidate commit 6b3ffba in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.
|
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz | 6b3ffba | 1788989672 | BridgeAR/2026-09-03-native-crash-proxy |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| receiver_entry_point/report/2644 | execution_time | 6.292ms | 6.332ms ± 0.017ms | 6.332ms ± 0.012ms | 6.342ms | 6.359ms | 6.373ms | 6.390ms | 0.91% | 0.246 | 0.057 | 0.27% | 0.001ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| receiver_entry_point/report/2644 | execution_time | [6.330ms; 6.334ms] or [-0.038%; +0.038%] | None | None | None |
Baseline
Baseline benchmark details
Group 1
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz | a2a1dfb | 1788978547 | main |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| receiver_entry_point/report/2644 | execution_time | 6.273ms | 6.335ms ± 0.023ms | 6.337ms ± 0.012ms | 6.346ms | 6.367ms | 6.377ms | 6.494ms | 2.48% | 1.484 | 11.141 | 0.36% | 0.002ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| receiver_entry_point/report/2644 | execution_time | [6.332ms; 6.338ms] or [-0.050%; +0.050%] | None | None | None |
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
The crash receiver inherits proxy environment variables from language tracers, but crashtracker linked libdd-common without its proxy feature. Direct telemetry and Errors Tracking uploads therefore bypassed configured egress proxies.
137bd19 to
6b3ffba
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
* chore(deps): bump libdd-crashtracker from v43.0.0 to v44.0.0 Bumps [libdd-crashtracker](https://github.com/DataDog/libdatadog) from v43.0.0 to v44.0.0. - [Release notes](https://github.com/DataDog/libdatadog/releases) - [Commits](DataDog/libdatadog@8c3d06b...8dba9be) --- updated-dependencies: - dependency-name: libdd-crashtracker dependency-version: 8dba9be608993b6222766ed8b7f742ce01461770 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * chore(crashtracker): remove redundant libdd-common dependency libdd-crashtracker v44 enables proxy support on its own libdd-common dependency, so the Node binding no longer needs to force the feature separately. Refs: DataDog/libdatadog#2462 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
What does this PR do?
Enables
libdd-common's existing proxy connector for crash report uploads and adds an integration test for direct telemetry and Errors Tracking requests.Motivation
Language tracers pass proxy environment variables to the isolated crash receiver, but
libdd-crashtrackerlinkedlibdd-commonwithout itshyper-proxyfeature. Direct uploads therefore bypassed configured egress proxies.How to test the change?
cargo test -p libdd-crashtracker --test proxy direct_crash_requests_use_https_proxy -- --exactcargo test -p libdd-crashtracker --features libdd-crashtracker/generate-unit-test-files -- --test-threads=1Refs: DataDog/dd-trace-js#10121