Skip to content

fix(crashtracking): honor proxy environment variables - #2462

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
BridgeAR/2026-09-03-native-crash-proxy
Sep 10, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
BridgeAR/2026-09-03-native-crash-proxy

Conversation

@BridgeAR

@BridgeAR BridgeAR commented Sep 3, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Enables libdd-common's existing proxy connector for crash report uploads and adds an integration test for direct telemetry and Errors Tracking requests.

Motivation

Language tracers pass proxy environment variables to the isolated crash receiver, but libdd-crashtracker linked libdd-common without its hyper-proxy feature. Direct uploads therefore bypassed configured egress proxies.

How to test the change?

  • cargo test -p libdd-crashtracker --test proxy direct_crash_requests_use_https_proxy -- --exact
  • cargo test -p libdd-crashtracker --features libdd-crashtracker/generate-unit-test-files -- --test-threads=1

Refs: DataDog/dd-trace-js#10121

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Tests

✅ All CI checks and tests passed.

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 77.70% (+0.07%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6b3ffba | Docs | View more details | Give us feedback!

@pr-commenter

pr-commenter Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Benchmarks

Comparison

Benchmark execution time: 2026-09-09 21:58:28

Comparing candidate commit 6b3ffba in PR branch BridgeAR/2026-09-03-native-crash-proxy with baseline commit a2a1dfb in branch main.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz 6b3ffba 1788989672 BridgeAR/2026-09-03-native-crash-proxy
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2644 execution_time 6.292ms 6.332ms ± 0.017ms 6.332ms ± 0.012ms 6.342ms 6.359ms 6.373ms 6.390ms 0.91% 0.246 0.057 0.27% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2644 execution_time [6.330ms; 6.334ms] or [-0.038%; +0.038%] None None None

Baseline

Baseline benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz a2a1dfb 1788978547 main
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2644 execution_time 6.273ms 6.335ms ± 0.023ms 6.337ms ± 0.012ms 6.346ms 6.367ms 6.377ms 6.494ms 2.48% 1.484 11.141 0.36% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2644 execution_time [6.332ms; 6.338ms] or [-0.050%; +0.050%] None None None

@dd-octo-sts

dd-octo-sts Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.96 MB 9.02 MB +.70% (+64.32 KB) 🔍
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 95.57 MB 95.83 MB +.27% (+266.99 KB) 🔍
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 106.92 MB 107.20 MB +.25% (+284.42 KB) 🔍
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 12.10 MB 12.18 MB +.66% (+82.33 KB) 🔍
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 28.91 MB 28.97 MB +.18% (+53.50 KB) 🔍
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 96.08 KB 96.08 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 191.08 MB 191.46 MB +.20% (+392.00 KB) 🔍
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 810.01 MB 814.65 MB +.57% (+4.63 MB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 9.65 MB 9.68 MB +.39% (+39.00 KB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 96.08 KB 96.08 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 27.37 MB 27.46 MB +.31% (+88.00 KB) 🔍
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 55.31 MB 55.53 MB +.39% (+224.03 KB) 🔍
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 25.26 MB 25.31 MB +.19% (+49.50 KB) 🔍
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 97.58 KB 97.58 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 196.30 MB 196.66 MB +.18% (+368.00 KB) 🔍
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 795.90 MB 799.80 MB +.49% (+3.90 MB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 7.46 MB 7.49 MB +.41% (+31.50 KB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 97.58 KB 97.58 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 29.44 MB 29.55 MB +.37% (+112.00 KB) 🔍
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 52.22 MB 52.44 MB +.42% (+228.31 KB) 🔍
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 85.61 MB 85.83 MB +.26% (+228.77 KB) 🔍
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 9.99 MB 10.02 MB +.27% (+28.34 KB) 🔍
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 101.52 MB 101.76 MB +.23% (+246.83 KB) 🔍
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 12.20 MB 12.25 MB +.37% (+46.37 KB) 🔍

The crash receiver inherits proxy environment variables from language tracers, but crashtracker linked libdd-common without its proxy feature. Direct telemetry and Errors Tracking uploads therefore bypassed configured egress proxies.
@BridgeAR
BridgeAR force-pushed the BridgeAR/2026-09-03-native-crash-proxy branch from 137bd19 to 6b3ffba Compare September 9, 2026 21:43
@BridgeAR
BridgeAR marked this pull request as ready for review September 9, 2026 21:45
@BridgeAR
BridgeAR requested review from a team as code owners September 9, 2026 21:45
@BridgeAR

Copy link
Copy Markdown
Member Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-10 11:34:32 UTC ℹ️ Start processing command /merge


2026-09-10 11:34:38 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 49m (p90).


2026-09-10 12:13:34 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 96d64dd into main Sep 10, 2026
99 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the BridgeAR/2026-09-03-native-crash-proxy branch September 10, 2026 12:13
BridgeAR added a commit to DataDog/libdatadog-nodejs that referenced this pull request Sep 15, 2026
* chore(deps): bump libdd-crashtracker from v43.0.0 to v44.0.0

Bumps [libdd-crashtracker](https://github.com/DataDog/libdatadog) from v43.0.0 to v44.0.0.
- [Release notes](https://github.com/DataDog/libdatadog/releases)
- [Commits](DataDog/libdatadog@8c3d06b...8dba9be)

---
updated-dependencies:
- dependency-name: libdd-crashtracker
  dependency-version: 8dba9be608993b6222766ed8b7f742ce01461770
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore(crashtracker): remove redundant libdd-common dependency

libdd-crashtracker v44 enables proxy support on its own libdd-common dependency, so the Node binding no longer needs to force the feature separately.

Refs: DataDog/libdatadog#2462

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants