Skip to content

chore(crashtracker): ping doesn't need siginfo #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gyuheon0h wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore(crashtracker): ping doesn't need siginfo #1522

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e31649
Ping doesn't need siginfo
gyuheon0h Feb 6, 2026
2e9beba
Comma
gyuheon0h Feb 6, 2026
568f5af
Trigger CI
gyuheon0h Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libdd-crashtracker-ffi/src/crash_info/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ pub unsafe extern "C" fn ddog_crasht_CrashInfoBuilder_with_thread_name(
/// The `builder` can be null, but if non-null it must point to a Builder made by this module,
/// which has not previously been dropped.
/// All arguments must be valid.
/// This method requires that the builder has a UUID, siginfo, and metadata set
Copy link
Contributor

@danielsn danielsn Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For non-siginfo crashes, we should still have an error type right?

/// This method requires that the builder has a UUID and metadata set
#[no_mangle]
#[must_use]
#[named]
Expand Down
Loading