Skip to content

chore(crashtracker): ping doesn't need siginfo#1522

Open
gyuheon0h wants to merge 3 commits intomainfrom
gyuheon0h/no-siginfo-ping
Open

chore(crashtracker): ping doesn't need siginfo#1522
gyuheon0h wants to merge 3 commits intomainfrom
gyuheon0h/no-siginfo-ping

Conversation

@gyuheon0h
Copy link
Contributor

@gyuheon0h gyuheon0h commented Feb 6, 2026

What does this PR do?

Update to inline comment that crash ping requires siginfo. It doesn't.

Motivation

This was raised as I implement crashtracking for non-signal based crashes. Non-signal based crashes don't have siginfo.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@gyuheon0h gyuheon0h requested a review from a team as a code owner February 6, 2026 00:39
@gyuheon0h gyuheon0h changed the title chore(crashtrackere): ping doesn't need siginfo chore(crashtracker): ping doesn't need siginfo Feb 6, 2026
@pr-commenter
Copy link

pr-commenter bot commented Feb 6, 2026 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2026-02-06 14:39:17

Comparing candidate commit 568f5af in PR branch gyuheon0h/no-siginfo-ping with baseline commit f483c69 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 568f5af 1770387786 gyuheon0h/no-siginfo-ping
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 241.131ns 252.457ns ± 13.665ns 247.203ns ± 3.623ns 253.029ns 287.241ns 288.417ns 289.124ns 16.96% 1.825 1.971 5.40% 0.966ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [250.563ns; 254.351ns] or [-0.750%; +0.750%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 568f5af 1770387786 gyuheon0h/no-siginfo-ping
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.972µs 5.052µs ± 0.034µs 5.048µs ± 0.023µs 5.071µs 5.112µs 5.116µs 5.120µs 1.43% 0.093 -0.616 0.67% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.048µs; 5.057µs] or [-0.093%; +0.093%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 568f5af 1770387786 gyuheon0h/no-siginfo-ping
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.334µs 2.392µs ± 0.017µs 2.393µs ± 0.006µs 2.399µs 2.409µs 2.419µs 2.493µs 4.21% -0.090 8.572 0.69% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.389µs; 2.394µs] or [-0.096%; +0.096%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 568f5af 1770387786 gyuheon0h/no-siginfo-ping
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 535.169µs 537.096µs ± 1.544µs 536.582µs ± 0.894µs 537.937µs 540.135µs 541.353µs 544.493µs 1.47% 1.347 2.424 0.29% 0.109µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1836569.513op/s 1861878.462op/s ± 5331.818op/s 1863646.422op/s ± 3104.025op/s 1866202.553op/s 1867333.994op/s 1868124.162op/s 1868567.593op/s 0.26% -1.324 2.307 0.29% 377.016op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 381.360µs 382.013µs ± 0.297µs 382.006µs ± 0.216µs 382.217µs 382.499µs 382.645µs 383.421µs 0.37% 0.598 1.543 0.08% 0.021µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2608096.825op/s 2617712.565op/s ± 2037.330op/s 2617759.186op/s ± 1483.285op/s 2619326.628op/s 2620658.776op/s 2621451.015op/s 2622193.056op/s 0.17% -0.591 1.514 0.08% 144.061op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 189.330µs 189.708µs ± 0.201µs 189.667µs ± 0.123µs 189.817µs 190.123µs 190.222µs 190.348µs 0.36% 0.751 0.170 0.11% 0.014µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5253549.075op/s 5271271.407op/s ± 5576.983op/s 5272411.653op/s ± 3428.149op/s 5275251.105op/s 5278739.366op/s 5280599.065op/s 5281783.130op/s 0.18% -0.746 0.161 0.11% 394.352op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 36.492µs 36.587µs ± 0.072µs 36.578µs ± 0.031µs 36.610µs 36.671µs 36.857µs 37.215µs 1.74% 4.297 30.532 0.20% 0.005µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26870561.128op/s 27332311.529op/s ± 53454.706op/s 27338756.994op/s ± 23399.809op/s 27360386.279op/s 27385641.763op/s 27400096.435op/s 27403190.027op/s 0.24% -4.215 29.582 0.20% 3779.819op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.881µs 46.046µs ± 0.055µs 46.044µs ± 0.035µs 46.078µs 46.133µs 46.195µs 46.314µs 0.59% 0.793 2.622 0.12% 0.004µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21591727.777op/s 21717672.074op/s ± 25904.774op/s 21718487.381op/s ± 16462.690op/s 21736237.522op/s 21755542.206op/s 21762408.490op/s 21795561.988op/s 0.35% -0.778 2.570 0.12% 1831.744op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [536.882µs; 537.310µs] or [-0.040%; +0.040%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1861139.524op/s; 1862617.401op/s] or [-0.040%; +0.040%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [381.972µs; 382.054µs] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2617430.211op/s; 2617994.920op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [189.680µs; 189.736µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5270498.491op/s; 5272044.323op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [36.577µs; 36.597µs] or [-0.027%; +0.027%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [27324903.221op/s; 27339719.837op/s] or [-0.027%; +0.027%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [46.038µs; 46.053µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21714081.922op/s; 21721262.227op/s] or [-0.017%; +0.017%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 568f5af 1770387786 gyuheon0h/no-siginfo-ping
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 84.798µs 85.176µs ± 0.179µs 85.150µs ± 0.081µs 85.244µs 85.408µs 85.672µs 86.685µs 1.80% 3.481 24.967 0.21% 0.013µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [85.151µs; 85.201µs] or [-0.029%; +0.029%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 568f5af 1770387786 gyuheon0h/no-siginfo-ping
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample2_frames_x1000 execution_time 546.313µs 547.427µs ± 0.778µs 547.322µs ± 0.342µs 547.692µs 548.366µs 550.397µs 553.326µs 1.10% 3.353 18.957 0.14% 0.055µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample2_frames_x1000 execution_time [547.320µs; 547.535µs] or [-0.020%; +0.020%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 568f5af 1770387786 gyuheon0h/no-siginfo-ping
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 144.344µs 146.230µs ± 1.723µs 145.995µs ± 0.554µs 146.562µs 147.805µs 152.277µs 162.753µs 11.48% 6.151 50.417 1.18% 0.122µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [145.991µs; 146.469µs] or [-0.163%; +0.163%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 568f5af 1770387786 gyuheon0h/no-siginfo-ping
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.595ms 10.627ms ± 0.013ms 10.626ms ± 0.008ms 10.634ms 10.651ms 10.664ms 10.706ms 0.76% 1.526 6.296 0.12% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.625ms; 10.629ms] or [-0.017%; +0.017%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 568f5af 1770387786 gyuheon0h/no-siginfo-ping
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 47.699ms 48.008ms ± 1.102ms 47.848ms ± 0.067ms 47.926ms 48.073ms 54.559ms 57.916ms 21.04% 8.008 64.834 2.29% 0.078ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [47.856ms; 48.161ms] or [-0.318%; +0.318%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 568f5af 1770387786 gyuheon0h/no-siginfo-ping
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_frames_x1000 execution_time 3.983ms 3.989ms ± 0.009ms 3.988ms ± 0.002ms 3.990ms 3.993ms 4.017ms 4.096ms 2.72% 8.738 94.026 0.23% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_frames_x1000 execution_time [3.988ms; 3.991ms] or [-0.032%; +0.032%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 568f5af 1770387786 gyuheon0h/no-siginfo-ping
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 188.561ns 190.893ns ± 2.080ns 190.667ns ± 1.403ns 191.886ns 194.645ns 197.779ns 201.611ns 5.74% 1.663 4.779 1.09% 0.147ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [190.605ns; 191.181ns] or [-0.151%; +0.151%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 568f5af 1770387786 gyuheon0h/no-siginfo-ping
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.250µs 3.297µs ± 1.449µs 3.078µs ± 0.027µs 3.104µs 3.747µs 14.378µs 15.016µs 387.80% 7.316 54.821 43.84% 0.102µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.096µs; 3.498µs] or [-6.092%; +6.092%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 568f5af 1770387786 gyuheon0h/no-siginfo-ping
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.418µs 34.028µs ± 0.940µs 33.584µs ± 0.065µs 33.754µs 36.020µs 36.091µs 37.336µs 11.17% 1.713 1.163 2.76% 0.066µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.897µs; 34.158µs] or [-0.383%; +0.383%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 568f5af 1770387786 gyuheon0h/no-siginfo-ping
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.893µs 3.912µs ± 0.003µs 3.912µs ± 0.001µs 3.913µs 3.915µs 3.920µs 3.926µs 0.38% -0.475 11.912 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 254688834.390op/s 255644454.156op/s ± 187782.289op/s 255649100.285op/s ± 92986.455op/s 255742741.015op/s 255877817.171op/s 255950177.170op/s 256893733.802op/s 0.49% 0.505 12.021 0.07% 13278.213op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 77.036µs 77.481µs ± 0.454µs 77.311µs ± 0.200µs 77.713µs 78.245µs 78.993µs 79.897µs 3.35% 1.766 4.492 0.58% 0.032µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12516061.477op/s 12906825.558op/s ± 74798.154op/s 12934804.724op/s ± 33579.653op/s 12963223.012op/s 12973117.314op/s 12979186.046op/s 12981003.599op/s 0.36% -1.708 4.123 0.58% 5289.028op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 70.629µs 70.916µs ± 0.301µs 70.779µs ± 0.095µs 71.033µs 71.507µs 71.894µs 72.304µs 2.15% 1.891 3.962 0.42% 0.021µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13830538.240op/s 14101413.237op/s ± 59472.284op/s 14128415.068op/s ± 18894.247op/s 14139929.748op/s 14151510.366op/s 14155294.660op/s 14158539.899op/s 0.21% -1.861 3.791 0.42% 4205.326op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.891µs 3.913µs ± 0.004µs 3.913µs ± 0.002µs 3.915µs 3.919µs 3.924µs 3.930µs 0.44% -0.089 6.938 0.10% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254421481.173op/s 255542280.665op/s ± 248357.963op/s 255544897.025op/s ± 139570.144op/s 255699124.255op/s 255853178.042op/s 255903980.608op/s 256996650.902op/s 0.57% 0.115 7.016 0.10% 17561.560op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 67.391µs 67.694µs ± 0.362µs 67.529µs ± 0.059µs 67.777µs 68.380µs 69.103µs 69.797µs 3.36% 2.648 8.481 0.53% 0.026µs 1 200
credit_card/is_card_number/378282246310005 throughput 14327231.449op/s 14772842.853op/s ± 77809.356op/s 14808436.368op/s ± 12979.096op/s 14816923.520op/s 14825997.387op/s 14832077.007op/s 14838788.593op/s 0.20% -2.594 8.070 0.53% 5501.952op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 44.812µs 45.103µs ± 0.123µs 45.105µs ± 0.088µs 45.188µs 45.313µs 45.387µs 45.418µs 0.69% 0.099 -0.306 0.27% 0.009µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 22017789.581op/s 22171395.564op/s ± 60219.503op/s 22170462.293op/s ± 43076.627op/s 22214392.149op/s 22266514.530op/s 22307946.662op/s 22315473.650op/s 0.65% -0.085 -0.308 0.27% 4258.162op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.028µs 6.036µs ± 0.011µs 6.035µs ± 0.002µs 6.037µs 6.042µs 6.102µs 6.106µs 1.18% 5.255 28.616 0.18% 0.001µs 1 200
credit_card/is_card_number/x371413321323331 throughput 163786717.253op/s 165665830.059op/s ± 300917.833op/s 165713273.310op/s ± 65931.295op/s 165784721.492op/s 165839669.005op/s 165890243.068op/s 165902373.666op/s 0.11% -5.238 28.488 0.18% 21278.104op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.904µs 3.912µs ± 0.002µs 3.912µs ± 0.001µs 3.914µs 3.916µs 3.917µs 3.921µs 0.23% 0.199 1.626 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255020338.770op/s 255597082.781op/s ± 149214.856op/s 255599488.801op/s ± 97014.096op/s 255683825.991op/s 255830281.792op/s 255917447.185op/s 256129650.504op/s 0.21% -0.192 1.618 0.06% 10551.084op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 65.484µs 65.767µs ± 0.072µs 65.776µs ± 0.041µs 65.817µs 65.870µs 65.888µs 65.917µs 0.21% -0.910 1.296 0.11% 0.005µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15170546.384op/s 15205220.643op/s ± 16659.962op/s 15203120.442op/s ± 9528.797op/s 15212633.335op/s 15235955.971op/s 15256602.103op/s 15270990.252op/s 0.45% 0.918 1.319 0.11% 1178.037op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 52.944µs 53.021µs ± 0.037µs 53.014µs ± 0.019µs 53.038µs 53.095µs 53.145µs 53.160µs 0.28% 1.177 2.094 0.07% 0.003µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 18811027.602op/s 18860348.610op/s ± 13292.659op/s 18863044.466op/s ± 6616.016op/s 18868081.341op/s 18878229.154op/s 18883909.325op/s 18887838.121op/s 0.13% -1.171 2.078 0.07% 939.933op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.896µs 3.912µs ± 0.003µs 3.912µs ± 0.001µs 3.913µs 3.916µs 3.919µs 3.923µs 0.28% -0.317 8.587 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254913566.157op/s 255626474.109op/s ± 170813.680op/s 255634199.757op/s ± 95720.645op/s 255744921.598op/s 255822961.306op/s 255857917.051op/s 256706443.282op/s 0.42% 0.338 8.683 0.07% 12078.351op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 49.745µs 49.810µs ± 0.044µs 49.799µs ± 0.021µs 49.824µs 49.905µs 49.941µs 49.991µs 0.38% 1.413 2.076 0.09% 0.003µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 20003757.920op/s 20076268.332op/s ± 17546.404op/s 20080603.142op/s ± 8344.351op/s 20086770.853op/s 20097784.923op/s 20101851.521op/s 20102657.571op/s 0.11% -1.407 2.057 0.09% 1240.718op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 44.721µs 45.070µs ± 0.139µs 45.076µs ± 0.099µs 45.167µs 45.288µs 45.326µs 45.351µs 0.61% -0.215 -0.421 0.31% 0.010µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 22050042.074op/s 22187959.462op/s ± 68400.264op/s 22184866.595op/s ± 48551.666op/s 22236026.818op/s 22292565.463op/s 22358810.360op/s 22360960.905op/s 0.79% 0.230 -0.409 0.31% 4836.629op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.028µs 6.037µs ± 0.011µs 6.035µs ± 0.003µs 6.039µs 6.044µs 6.103µs 6.111µs 1.26% 5.404 32.550 0.18% 0.001µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 163629271.568op/s 165643566.230op/s ± 293061.819op/s 165690240.845op/s ± 83146.425op/s 165764872.085op/s 165852453.238op/s 165877158.133op/s 165898215.188op/s 0.13% -5.376 32.303 0.18% 20722.600op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.911µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [255618429.337op/s; 255670478.975op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [77.418µs; 77.544µs] or [-0.081%; +0.081%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12896459.253op/s; 12917191.863op/s] or [-0.080%; +0.080%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [70.874µs; 70.958µs] or [-0.059%; +0.059%] None None None
credit_card/is_card_number/ 378282246310005 throughput [14093170.951op/s; 14109655.524op/s] or [-0.058%; +0.058%] None None None
credit_card/is_card_number/37828224631 execution_time [3.913µs; 3.914µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/37828224631 throughput [255507860.640op/s; 255576700.690op/s] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/378282246310005 execution_time [67.644µs; 67.744µs] or [-0.074%; +0.074%] None None None
credit_card/is_card_number/378282246310005 throughput [14762059.225op/s; 14783626.482op/s] or [-0.073%; +0.073%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [45.087µs; 45.120µs] or [-0.038%; +0.038%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [22163049.720op/s; 22179741.408op/s] or [-0.038%; +0.038%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.035µs; 6.038µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number/x371413321323331 throughput [165624125.742op/s; 165707534.377op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.912µs; 3.913µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ throughput [255576403.037op/s; 255617762.525op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [65.757µs; 65.777µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15202911.732op/s; 15207529.553op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [53.016µs; 53.026µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [18858506.376op/s; 18862190.845op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.912µs; 3.912µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255602800.975op/s; 255650147.242op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [49.804µs; 49.816µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [20073836.570op/s; 20078700.095op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [45.051µs; 45.089µs] or [-0.043%; +0.043%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [22178479.843op/s; 22197439.081op/s] or [-0.043%; +0.043%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.036µs; 6.039µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165602950.680op/s; 165684181.780op/s] or [-0.025%; +0.025%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 568f5af 1770387786 gyuheon0h/no-siginfo-ping
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 160.679µs 161.675µs ± 0.652µs 161.598µs ± 0.177µs 161.815µs 162.140µs 162.388µs 169.911µs 5.14% 10.179 126.067 0.40% 0.046µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [161.585µs; 161.765µs] or [-0.056%; +0.056%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 568f5af 1770387786 gyuheon0h/no-siginfo-ping
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.089µs 26.287µs ± 9.461µs 18.716µs ± 0.543µs 34.634µs 42.365µs 49.050µs 59.199µs 216.31% 0.734 -0.621 35.90% 0.669µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.976µs; 27.598µs] or [-4.988%; +4.988%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 568f5af 1770387786 gyuheon0h/no-siginfo-ping
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 14.008ms 14.065ms ± 0.028ms 14.061ms ± 0.014ms 14.075ms 14.115ms 14.155ms 14.239ms 1.26% 2.019 7.727 0.20% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.061ms; 14.069ms] or [-0.028%; +0.028%] None None None

Group 18

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 568f5af 1770387786 gyuheon0h/no-siginfo-ping
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 9.655ms 9.867ms ± 0.067ms 9.880ms ± 0.030ms 9.906ms 9.941ms 10.001ms 10.016ms 1.38% -1.191 1.670 0.67% 0.005ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [9.858ms; 9.876ms] or [-0.094%; +0.094%] None None None

Group 19

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 568f5af 1770387786 gyuheon0h/no-siginfo-ping
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 206.009µs 206.475µs ± 0.214µs 206.451µs ± 0.129µs 206.591µs 206.851µs 207.203µs 207.235µs 0.38% 0.809 1.187 0.10% 0.015µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4825434.054op/s 4843197.305op/s ± 5008.068op/s 4843776.111op/s ± 3022.196op/s 4846602.414op/s 4849914.577op/s 4853496.430op/s 4854159.405op/s 0.21% -0.801 1.167 0.10% 354.124op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.595µs 18.663µs ± 0.088µs 18.651µs ± 0.017µs 18.670µs 18.724µs 18.751µs 19.828µs 6.31% 11.563 149.738 0.47% 0.006µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 50434074.971op/s 53583489.549op/s ± 240668.340op/s 53617755.845op/s ± 48922.007op/s 53660437.660op/s 53719170.525op/s 53761844.518op/s 53778755.113op/s 0.30% -11.304 145.160 0.45% 17017.822op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.871µs 10.938µs ± 0.089µs 10.933µs ± 0.022µs 10.952µs 10.982µs 11.039µs 12.103µs 10.71% 11.330 145.591 0.81% 0.006µs 1 200
normalization/normalize_name/normalize_name/good throughput 82621328.791op/s 91430384.330op/s ± 682527.253op/s 91466011.684op/s ± 183774.644op/s 91666741.107op/s 91862848.487op/s 91906164.412op/s 91989860.049op/s 0.57% -10.856 137.284 0.74% 48261.965op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [206.446µs; 206.505µs] or [-0.014%; +0.014%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4842503.235op/s; 4843891.375op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.651µs; 18.675µs] or [-0.066%; +0.066%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53550135.231op/s; 53616843.866op/s] or [-0.062%; +0.062%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.926µs; 10.950µs] or [-0.113%; +0.113%] None None None
normalization/normalize_name/normalize_name/good throughput [91335792.617op/s; 91524976.043op/s] or [-0.103%; +0.103%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.23%. Comparing base (f483c69) to head (568f5af).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1522      +/-   ##
==========================================
+ Coverage   71.20%   71.23%   +0.03%     
==========================================
  Files         424      424              
  Lines       69802    69802              
==========================================
+ Hits        49700    49722      +22     
+ Misses      20102    20080      -22
Components Coverage Δ
libdd-crashtracker 62.37% <ø> (+0.01%) ⬆️
libdd-crashtracker-ffi 16.80% <ø> (ø)
libdd-alloc 98.73% <ø> (ø)
libdd-data-pipeline 86.86% <ø> (ø)
libdd-data-pipeline-ffi 78.68% <ø> (ø)
libdd-common 80.58% <ø> (ø)
libdd-common-ffi 74.54% <ø> (ø)
libdd-telemetry 65.09% <ø> (ø)
libdd-telemetry-ffi 21.17% <ø> (ø)
libdd-dogstatsd-client 83.75% <ø> (ø)
datadog-ipc 82.60% <ø> (ø)
libdd-profiling 81.73% <ø> (ø)
libdd-profiling-ffi 64.71% <ø> (ø)
datadog-sidecar 34.39% <ø> (ø)
datdog-sidecar-ffi 7.67% <ø> (ø)
spawn-worker 55.18% <ø> (ø)
libdd-tinybytes 93.43% <ø> (ø)
libdd-trace-normalization 82.33% <ø> (ø)
libdd-trace-obfuscation 94.17% <ø> (ø)
libdd-trace-protobuf 61.18% <ø> (ø)
libdd-trace-utils 89.37% <ø> (ø)
datadog-tracer-flare 62.06% <ø> (ø)
libdd-log 75.57% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gyuheon0h gyuheon0h requested a review from gleocadie February 6, 2026 01:05
@gyuheon0h
Copy link
Contributor Author

gyuheon0h commented Feb 6, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Feb 6, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-02-06 01:30:01 UTC ℹ️ Start processing command /merge

2026-02-06 01:30:06 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-02-06 05:30:19 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

danielsn
danielsn reviewed Feb 6, 2026
View reviewed changes
libdd-crashtracker-ffi/src/crash_info/builder.rs
/// The `builder` can be null, but if non-null it must point to a Builder made by this module,
/// which has not previously been dropped.
/// All arguments must be valid.
/// This method requires that the builder has a UUID, siginfo, and metadata set
Copy link
Contributor

@danielsn danielsn Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For non-siginfo crashes, we should still have an error type right?

@dd-octo-sts
Copy link

dd-octo-sts bot commented Feb 6, 2026

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.38 MB 8.38 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 91.69 MB 91.69 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.76 MB 10.76 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 106.40 MB 106.40 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 25.08 MB 25.08 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 75.94 KB 75.94 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 172.52 MB 172.53 MB +0% (+8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 882.84 MB 882.84 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 9.57 MB 9.57 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 75.94 KB 75.94 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 23.04 MB 23.04 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 48.45 MB 48.45 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 21.22 MB 21.22 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 77.12 KB 77.12 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 176.62 MB 176.63 MB +0% (+16.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 866.93 MB 866.93 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 7.24 MB 7.24 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 77.12 KB 77.12 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 24.62 MB 24.62 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 44.15 MB 44.15 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 80.18 MB 80.18 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 9.88 MB 9.88 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 100.31 MB 100.31 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.44 MB 11.44 MB 0% (0 B) 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielsn danielsn danielsn left review comments

@ekump ekump ekump approved these changes

@KowalskiThomas KowalskiThomas KowalskiThomas approved these changes

@gleocadie gleocadie gleocadie approved these changes

Assignees

No one assigned

Labels

crashtracker mergequeue-status: removed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gyuheon0h @codecov-commenter @ekump @danielsn @KowalskiThomas @gleocadie