revert(profiling): backend does not use MIME#1511
revert(profiling): backend does not use MIME#1511gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom
Conversation
📚 Documentation Check Results📦
|
🔒 Cargo Deny Results📦
|
BenchmarksComparisonBenchmark execution time: 2026-02-05 19:54:37 Comparing candidate commit 26cf397 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
5011a7e to
639878d
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1511 +/- ##
==========================================
+ Coverage 71.20% 71.22% +0.02%
==========================================
Files 424 424
Lines 69802 69776 -26
==========================================
- Hits 49700 49698 -2
+ Misses 20102 20078 -24
🚀 New features to boost your workflow:
|
morrisonlevi
left a comment
There was a problem hiding this comment.
Looks good to me but the original PR said that there was some failing test that we set the mime type to fix. What test? Do we need to ship a different fix in another PR?
There was an integration test for python that was failing. I talked with the owner of that test, and he agreed that given the response from the intake backend folks the test not the code should change. |
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
|
I've gone ahead and re-ran the Ruby profiler on this branch, comparing it to libdatadog v25. Here's a diff of how it's looking: --- v25-clean.txt 2026-02-05 09:05:28.917698767 +0000
+++ revert-mime-branch.txt 2026-02-05 09:05:23.406719836 +0000
@@ -1,36 +1,38 @@
Headers:
{
+ "accept"=>["*/*"],
"connection"=>["close"],
- "content-type"=>["multipart/form-data; boundary=m4W51A"],
+ "content-length"=>["12423"],
+ "content-type"=>
+ ["multipart/form-data; boundary=cd3a6ef9d14be1c3-5c59c95ac480b3e6-e66dc94ec70c8cce-492102b9194788d7"],
"datadog-container-id"=>["20743e83-1420-4204-97dc-ce2dbaa454f5"],
"datadog-entity-id"=>["ci-20743e83-1420-4204-97dc-ce2dbaa454f5"],
"dd-evp-origin"=>["dd-trace-rb"],
"dd-evp-origin-version"=>["2.29.0"],
"host"=>["127.0.0.1:8126"],
- "transfer-encoding"=>["chunked"],
"user-agent"=>["DDProf/1.0.0"]}
Multi-part:
{"code-provenance.json"=>
{:filename=>"code-provenance.json",
- :type=>"application/octet-stream",
+ :type=>nil,
:name=>"code-provenance.json",
:tempfile=>"...",
:head=>
- "content-type: application/octet-stream\r\ncontent-disposition: form-data; name=\"code-provenance.json\"; filename=\"code-provenance.json\"\r\n"},
+ "Content-Disposition: form-data; name=\"code-provenance.json\"; filename=\"code-provenance.json\"\r\n"},
"event"=>
{:filename=>"event.json",
:type=>"application/json",
:name=>"event",
:tempfile=>"...",
:head=>
- "content-type: application/json\r\ncontent-disposition: form-data; name=\"event\"; filename=\"event.json\"\r\n"},
+ "Content-Disposition: form-data; name=\"event\"; filename=\"event.json\"\r\nContent-Type: application/json\r\n"},
"profile.pprof"=>
{:filename=>"profile.pprof",
- :type=>"application/octet-stream",
+ :type=>nil,
:name=>"profile.pprof",
:tempfile=>"...",
:head=>
- "content-type: application/octet-stream\r\ncontent-disposition: form-data; name=\"profile.pprof\"; filename=\"profile.pprof\"\r\n"}}
+ "Content-Disposition: form-data; name=\"profile.pprof\"; filename=\"profile.pprof\"\r\n"}}TL;DR:
Is this correct/expected? |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
daniel.schwartznarbonne@datadoghq.com cancelled this merge request build |
|
/merge -c |
|
View all feedbacks in Devflow UI.
|
This makes sense to me, and to 🤖 . Adding the 🤖 answer for posterity: MIME type changes: expected and correct |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Tests failed on this commit 8e9ba7f: What to do next?
|
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
devflow unqueued this merge request: It did not become mergeable within the expected time |
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
3f007eb
into
main
What does this PR do?
Reverts #1478
Motivation
As per the event-platform-intake team:
// Note: We don't set Content-Type for file attachments in the multipart form.
// The intake backend treats all attachments as raw bytes (application/octet-stream)
// and detects compression by reading magic bytes (gzip/zstd/etc headers).
// Content-Type is only meaningful for the main "event" part (set to application/json).
// Attachments are not forwarded beyond intake, so their MIME types are not needed.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.